From 6167e753766cf90897025e89c60b073c6236ead1 Mon Sep 17 00:00:00 2001 From: jycouet Date: Mon, 1 Sep 2025 22:50:40 +0200 Subject: [PATCH 01/11] fix passing community option to addon --- packages/cli/commands/add/index.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cli/commands/add/index.ts b/packages/cli/commands/add/index.ts index 2439f7d1..3680d892 100644 --- a/packages/cli/commands/add/index.ts +++ b/packages/cli/commands/add/index.ts @@ -84,7 +84,8 @@ export const add = new Command('add') .option('--no-git-check', 'even if some files are dirty, no prompt will be shown') .option('--no-install', 'skip installing dependencies') .addOption(installOption) - //.option('--community [add-on...]', 'community addons to install') + // TODO JYC: remove the flag + .option('--community [add-on...]', 'community addons to install') .configureHelp({ ...common.helpConfig, formatHelp(cmd, helper) { @@ -550,7 +551,7 @@ export async function runAddCommand( workspace, addonSetupResults, addons: addonMap, - options: official + options: { ...official, ...community } }); p.log.success('Successfully setup add-ons'); From 1433f8896d0ef28594007da23b5ba6c640ae9865 Mon Sep 17 00:00:00 2001 From: jycouet Date: Wed, 3 Sep 2025 20:46:18 +0200 Subject: [PATCH 02/11] git mv folder --- .../create/templates/addon}/.gitignore | 0 .../create/templates/addon}/README.md | 0 .../create/templates/addon}/jsconfig.json | 0 .../create/templates/addon}/package.json | 0 .../create/templates/addon}/src/index.js | 0 .../create/templates/addon}/tests/custom-addon.test.ts | 0 .../create/templates/addon}/tests/fixtures/+page.svelte | 0 .../create/templates/addon}/tests/fixtures/App.svelte | 0 .../create/templates/addon}/tests/setup/global.ts | 0 .../create/templates/addon}/tests/setup/suite.ts | 0 .../create/templates/addon}/vitest.config.js | 0 11 files changed, 0 insertions(+), 0 deletions(-) rename {community-addon-template => packages/create/templates/addon}/.gitignore (100%) rename {community-addon-template => packages/create/templates/addon}/README.md (100%) rename {community-addon-template => packages/create/templates/addon}/jsconfig.json (100%) rename {community-addon-template => packages/create/templates/addon}/package.json (100%) rename {community-addon-template => packages/create/templates/addon}/src/index.js (100%) rename {community-addon-template => packages/create/templates/addon}/tests/custom-addon.test.ts (100%) rename {community-addon-template => packages/create/templates/addon}/tests/fixtures/+page.svelte (100%) rename {community-addon-template => packages/create/templates/addon}/tests/fixtures/App.svelte (100%) rename {community-addon-template => packages/create/templates/addon}/tests/setup/global.ts (100%) rename {community-addon-template => packages/create/templates/addon}/tests/setup/suite.ts (100%) rename {community-addon-template => packages/create/templates/addon}/vitest.config.js (100%) diff --git a/community-addon-template/.gitignore b/packages/create/templates/addon/.gitignore similarity index 100% rename from community-addon-template/.gitignore rename to packages/create/templates/addon/.gitignore diff --git a/community-addon-template/README.md b/packages/create/templates/addon/README.md similarity index 100% rename from community-addon-template/README.md rename to packages/create/templates/addon/README.md diff --git a/community-addon-template/jsconfig.json b/packages/create/templates/addon/jsconfig.json similarity index 100% rename from community-addon-template/jsconfig.json rename to packages/create/templates/addon/jsconfig.json diff --git a/community-addon-template/package.json b/packages/create/templates/addon/package.json similarity index 100% rename from community-addon-template/package.json rename to packages/create/templates/addon/package.json diff --git a/community-addon-template/src/index.js b/packages/create/templates/addon/src/index.js similarity index 100% rename from community-addon-template/src/index.js rename to packages/create/templates/addon/src/index.js diff --git a/community-addon-template/tests/custom-addon.test.ts b/packages/create/templates/addon/tests/custom-addon.test.ts similarity index 100% rename from community-addon-template/tests/custom-addon.test.ts rename to packages/create/templates/addon/tests/custom-addon.test.ts diff --git a/community-addon-template/tests/fixtures/+page.svelte b/packages/create/templates/addon/tests/fixtures/+page.svelte similarity index 100% rename from community-addon-template/tests/fixtures/+page.svelte rename to packages/create/templates/addon/tests/fixtures/+page.svelte diff --git a/community-addon-template/tests/fixtures/App.svelte b/packages/create/templates/addon/tests/fixtures/App.svelte similarity index 100% rename from community-addon-template/tests/fixtures/App.svelte rename to packages/create/templates/addon/tests/fixtures/App.svelte diff --git a/community-addon-template/tests/setup/global.ts b/packages/create/templates/addon/tests/setup/global.ts similarity index 100% rename from community-addon-template/tests/setup/global.ts rename to packages/create/templates/addon/tests/setup/global.ts diff --git a/community-addon-template/tests/setup/suite.ts b/packages/create/templates/addon/tests/setup/suite.ts similarity index 100% rename from community-addon-template/tests/setup/suite.ts rename to packages/create/templates/addon/tests/setup/suite.ts diff --git a/community-addon-template/vitest.config.js b/packages/create/templates/addon/vitest.config.js similarity index 100% rename from community-addon-template/vitest.config.js rename to packages/create/templates/addon/vitest.config.js From 15eadb1c4817f964d3c01f130af49115a011df28 Mon Sep 17 00:00:00 2001 From: jycouet Date: Wed, 3 Sep 2025 21:54:21 +0200 Subject: [PATCH 03/11] starting playing around --- .changeset/config.json | 2 +- .../docs/20-commands/10-sv-create.md | 1 + eslint.config.js | 1 - packages/cli/commands/create.ts | 6 +- packages/create/index.ts | 2 +- packages/create/scripts/build-templates.js | 9 +++ packages/create/shared/+addon/README.md | 61 +++++++++++++++++++ packages/create/templates/addon/.gitignore | 27 +++++++- packages/create/templates/addon/.ignore | 3 + packages/create/templates/addon/.meta.json | 4 ++ packages/create/templates/addon/README.md | 17 +++--- .../{package.json => package.template.json} | 17 ++---- pnpm-lock.yaml | 16 ----- pnpm-workspace.yaml | 2 +- vitest.config.ts | 2 +- 15 files changed, 126 insertions(+), 44 deletions(-) create mode 100644 packages/create/shared/+addon/README.md create mode 100644 packages/create/templates/addon/.ignore create mode 100644 packages/create/templates/addon/.meta.json rename packages/create/templates/addon/{package.json => package.template.json} (51%) diff --git a/.changeset/config.json b/.changeset/config.json index 9c12e3e3..8114d868 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -7,5 +7,5 @@ "access": "public", "baseBranch": "main", "updateInternalDependencies": "patch", - "ignore": [ "@sveltejs/*", "community-addon-template" ] + "ignore": [ "@sveltejs/*" ] } diff --git a/documentation/docs/20-commands/10-sv-create.md b/documentation/docs/20-commands/10-sv-create.md index fc4a4b93..9b0718f1 100644 --- a/documentation/docs/20-commands/10-sv-create.md +++ b/documentation/docs/20-commands/10-sv-create.md @@ -19,6 +19,7 @@ Which project template to use: - `minimal` — barebones scaffolding for your new app - `demo` — showcase app with a word guessing game that works without JavaScript - `library` — template for a Svelte library, set up with `svelte-package` +- `add-on` — template for a community add-on, ready to be tested & published ### `--types