fix(no-top-level-browser-globals): false positives for compound logical expression guards (#1305)

Co-authored-by: Yuichiro Yamashita <[email protected]>

Author: ota-meshi

.changeset/metal-poems-jog.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix(no-top-level-browser-globals): false positives for compound logical expression guards

packages/eslint-plugin-svelte/src/rules/no-top-level-browser-globals.ts

@@ -370,14 +370,23 @@ export default createRule('no-top-level-browser-globals', {
 
 				return (n) => start <= n.range[0] && n.range[1] <= end;
 			}
-			if (
-				!guardInfo.not &&
-				parent.type === 'LogicalExpression' &&
-				parent.operator === '&&' &&
-				parent.left === guardInfo.node
-			) {
-				const block = parent.right;
-				return (n) => block.range[0] <= n.range[0] && n.range[1] <= block.range[1];
+			if (parent.type === 'LogicalExpression') {
+				if (!guardInfo.not && parent.operator === '&&') {
+					const parentChecker = getGuardChecker({ not: guardInfo.not, node: parent });
+					if (parent.left === guardInfo.node) {
+						const block = parent.right;
+						return (n) => {
+							if (parentChecker?.(n)) {
+								return true;
+							}
+							return block.range[0] <= n.range[0] && n.range[1] <= block.range[1];
+						};
+					}
+					return parentChecker;
+				}
+				if (guardInfo.not && parent.operator === '||') {
+					return getGuardChecker({ not: guardInfo.not, node: parent });
+				}
 			}
 			return null;
 		}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-top-level-browser-globals/valid/complex-guards01-input.svelte

@@ -0,0 +1,7 @@
+<script>
+	import { browser, dev } from '$app/environment';
+</script>
+
+{#if browser && dev}
+	<div>{localStorage.getItem('myCat')}</div>
+{/if}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-top-level-browser-globals/valid/complex-guards02-input.svelte

@@ -0,0 +1,11 @@
+<script>
+	import { browser, dev } from '$app/environment';
+</script>
+
+{#if !browser || !dev}
+	<!-- (!(browser && dev))  -->
+	<div>DEV</div>
+{:else}
+	<!-- (browser && dev) -->
+	<div>{localStorage.getItem('myCat')}</div>
+{/if}