feat: Add ability to comment out attributes #17188
Open
+69
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant RFC, specifically this comment which has the most upvotes.
In short, this PR would allow comments in the form of
{/* some comment*/}where an html attribute is expected, e.g.This would be useful to quickly comment out single attributes of an HTML element.
What does not work is using this to comment out the entire tag, for that we already have normal html comments (
<!-- -->).Implementation wise this is an empty attribute which will then be ignored by the parser.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint