Skip to content

Commit 2c4f3dd

Browse files
author
sewardj
committed
Add some Helgrind suppressions for LinuxThreads.
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7146 a5019735-40e9-0310-863c-91ae7b9d1cf9
1 parent 1c814ec commit 2c4f3dd

4 files changed

+76
-6
lines changed

Makefile.am

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ DIST_SUBDIRS = $(SUBDIRS)
2020
SUPP_FILES = \
2121
glibc-2.2.supp glibc-2.3.supp glibc-2.4.supp glibc-2.5.supp \
2222
glibc-2.6.supp aix5libc.supp xfree-3.supp xfree-4.supp \
23-
glibc-2.X-helgrind.supp
23+
glibc-2.3456-NPTL-helgrind.supp \
24+
glibc-2.2-LinuxThreads-helgrind.supp
2425

2526
dist_val_DATA = $(SUPP_FILES) default.supp
2627

configure.in

+10-5
Original file line numberDiff line numberDiff line change
@@ -473,30 +473,35 @@ case "${libc}" in
473473
2.2)
474474
AC_MSG_RESULT(2.2 family)
475475
AC_DEFINE([GLIBC_2_2], 1, [Define to 1 if you're using glibc 2.2.x])
476-
DEFAULT_SUPP="glibc-2.2.supp glibc-2.X-helgrind.supp ${DEFAULT_SUPP}"
476+
DEFAULT_SUPP="glibc-2.2.supp ${DEFAULT_SUPP}"
477+
DEFAULT_SUPP="glibc-2.2-LinuxThreads-helgrind.supp ${DEFAULT_SUPP}"
477478
;;
478479

479480
2.3)
480481
AC_MSG_RESULT(2.3 family)
481482
AC_DEFINE([GLIBC_2_3], 1, [Define to 1 if you're using glibc 2.3.x])
482-
DEFAULT_SUPP="glibc-2.3.supp glibc-2.X-helgrind.supp ${DEFAULT_SUPP}"
483+
DEFAULT_SUPP="glibc-2.3.supp ${DEFAULT_SUPP}"
484+
DEFAULT_SUPP="glibc-2.3456-NPTL-helgrind.supp ${DEFAULT_SUPP}"
483485
;;
484486

485487
2.4)
486488
AC_MSG_RESULT(2.4 family)
487489
AC_DEFINE([GLIBC_2_4], 1, [Define to 1 if you're using glibc 2.4.x])
488-
DEFAULT_SUPP="glibc-2.4.supp glibc-2.X-helgrind.supp ${DEFAULT_SUPP}"
490+
DEFAULT_SUPP="glibc-2.4.supp ${DEFAULT_SUPP}"
491+
DEFAULT_SUPP="glibc-2.3456-NPTL-helgrind.supp ${DEFAULT_SUPP}"
489492
;;
490493

491494
2.5)
492495
AC_MSG_RESULT(2.5 family)
493496
AC_DEFINE([GLIBC_2_5], 1, [Define to 1 if you're using glibc 2.5.x])
494-
DEFAULT_SUPP="glibc-2.5.supp glibc-2.X-helgrind.supp ${DEFAULT_SUPP}"
497+
DEFAULT_SUPP="glibc-2.5.supp ${DEFAULT_SUPP}"
498+
DEFAULT_SUPP="glibc-2.3456-NPTL-helgrind.supp ${DEFAULT_SUPP}"
495499
;;
496500
2.6)
497501
AC_MSG_RESULT(2.6 family)
498502
AC_DEFINE([GLIBC_2_6], 1, [Define to 1 if you're using glibc 2.6.x])
499-
DEFAULT_SUPP="glibc-2.6.supp glibc-2.X-helgrind.supp ${DEFAULT_SUPP}"
503+
DEFAULT_SUPP="glibc-2.6.supp ${DEFAULT_SUPP}"
504+
DEFAULT_SUPP="glibc-2.3456-NPTL-helgrind.supp ${DEFAULT_SUPP}"
500505
;;
501506
aix5)
502507
AC_MSG_RESULT(AIX 5.1 or 5.2 or 5.3)

glibc-2.2-LinuxThreads-helgrind.supp

+64
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
2+
## Helgrind really doesn't support LinuxThreads-based threading
3+
## (which is absolutely ancient by now). But just in case anyone
4+
## is nuts enough to try it, here are some suppressions.
5+
6+
{
7+
helgrind-glibc22-LinuxThreads-1
8+
Helgrind:Race
9+
obj:/lib*/libpthread-0.10.so*
10+
}
11+
{
12+
helgrind-glibc22-LinuxThreads-2
13+
Helgrind:Race
14+
obj:/lib*/ld-2.2.*so*
15+
obj:/lib*/ld-2.2.*so*
16+
}
17+
{
18+
helgrind-glibc22-LinuxThreads-3
19+
Helgrind:Race
20+
obj:/lib*/libc-2.2.*so*
21+
obj:/lib*/libc-2.2.*so*
22+
}
23+
{
24+
helgrind-glibc22-LinuxThreads-4
25+
Helgrind:Race
26+
obj:/lib*/ld-2.2.*so*
27+
obj:/lib*/libc-2.2.*so*
28+
}
29+
{
30+
helgrind-glibc22-LinuxThreads-5
31+
Helgrind:Race
32+
obj:/lib*/libc-2.2.*so*
33+
fun:pthread_*
34+
}
35+
{
36+
helgrind-glibc22-LinuxThreads-6
37+
Helgrind:Race
38+
fun:pthread_*
39+
obj:/lib*/libc-2.2.*so*
40+
}
41+
{
42+
helgrind-glibc22-LinuxThreads-7
43+
Helgrind:Race
44+
fun:mythread_wrapper
45+
fun:pthread_*
46+
}
47+
{
48+
helgrind-glibc22-LinuxThreads-8
49+
Helgrind:Misc
50+
fun:pthread_mutex_lock
51+
fun:_IO_*
52+
}
53+
{
54+
helgrind-glibc22-LinuxThreads-9
55+
Helgrind:UnlockForeign
56+
fun:pthread_mutex_unlock
57+
fun:_IO_*
58+
}
59+
{
60+
helgrind-glibc22-LinuxThreads-10
61+
Helgrind:Misc
62+
fun:_Exit
63+
obj:/lib*/libpthread-0.10.so*
64+
}
File renamed without changes.

0 commit comments

Comments
 (0)