Skip to content

Commit 6d982cc

Browse files
author
florian
committed
Fix a few VG_(message) invocations. The function does not add a
newline character under the covers. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@14796 a5019735-40e9-0310-863c-91ae7b9d1cf9
1 parent 46b5433 commit 6d982cc

File tree

5 files changed

+26
-27
lines changed

5 files changed

+26
-27
lines changed

coregrind/m_syswrap/syswrap-arm-linux.c

+6-7
Original file line numberDiff line numberDiff line change
@@ -497,13 +497,12 @@ PRE(sys_clone)
497497

498498
default:
499499
/* should we just ENOSYS? */
500-
VG_(message)(Vg_UserMsg, "");
501-
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG1);
502-
VG_(message)(Vg_UserMsg, "");
503-
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
504-
VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)");
505-
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
506-
VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver");
500+
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG1);
501+
VG_(message)(Vg_UserMsg, "\n");
502+
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
503+
VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)\n");
504+
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
505+
VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver\n");
507506
VG_(unimplemented)
508507
("Valgrind does not support general clone().");
509508
}

coregrind/m_syswrap/syswrap-arm64-linux.c

+6-7
Original file line numberDiff line numberDiff line change
@@ -601,13 +601,12 @@ PRE(sys_clone)
601601

602602
default:
603603
/* should we just ENOSYS? */
604-
VG_(message)(Vg_UserMsg, "");
605-
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG1);
606-
VG_(message)(Vg_UserMsg, "");
607-
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
608-
VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)");
609-
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
610-
VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver");
604+
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG1);
605+
VG_(message)(Vg_UserMsg, "\n");
606+
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
607+
VG_(message)(Vg_UserMsg, " - via a threads library (LinuxThreads or NPTL)\n");
608+
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
609+
VG_(message)(Vg_UserMsg, " - for the Quadrics Elan3 user-space driver\n");
611610
VG_(unimplemented)
612611
("Valgrind does not support general clone().");
613612
}

coregrind/m_syswrap/syswrap-darwin.c

+7-6
Original file line numberDiff line numberDiff line change
@@ -647,22 +647,23 @@ void VG_(show_open_ports)(void)
647647
OpenPort *i;
648648

649649
VG_(message)(Vg_UserMsg,
650-
"MACH PORTS: %d open at exit.", allocated_port_count);
650+
"MACH PORTS: %d open at exit.\n", allocated_port_count);
651651

652652
for (i = allocated_ports; i; i = i->next) {
653653
if (i->name) {
654-
VG_(message)(Vg_UserMsg, "Open Mach port 0x%x: %s", i->port, i->name);
654+
VG_(message)(Vg_UserMsg, "Open Mach port 0x%x: %s\n", i->port,
655+
i->name);
655656
} else {
656-
VG_(message)(Vg_UserMsg, "Open Mach port 0x%x", i->port);
657+
VG_(message)(Vg_UserMsg, "Open Mach port 0x%x\n", i->port);
657658
}
658659

659660
if (i->where) {
660661
VG_(pp_ExeContext)(i->where);
661-
VG_(message)(Vg_UserMsg, "");
662+
VG_(message)(Vg_UserMsg, "\n");
662663
}
663664
}
664665

665-
VG_(message)(Vg_UserMsg, "");
666+
VG_(message)(Vg_UserMsg, "\n");
666667
}
667668

668669

@@ -3997,7 +3998,7 @@ PRE(auditon)
39973998
break;
39983999

39994000
default:
4000-
VG_(message)(Vg_UserMsg, "UNKNOWN auditon cmd %ld", ARG1);
4001+
VG_(message)(Vg_UserMsg, "UNKNOWN auditon cmd %ld\n", ARG1);
40014002
break;
40024003
}
40034004
}

coregrind/m_syswrap/syswrap-s390x-linux.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -525,11 +525,11 @@ PRE(sys_clone)
525525

526526
default:
527527
/* should we just ENOSYS? */
528-
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx", ARG2);
529-
VG_(message)(Vg_UserMsg, "");
530-
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:");
531-
VG_(message)(Vg_UserMsg, " - via a threads library (NPTL)");
532-
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork");
528+
VG_(message)(Vg_UserMsg, "Unsupported clone() flags: 0x%lx\n", ARG2);
529+
VG_(message)(Vg_UserMsg, "\n");
530+
VG_(message)(Vg_UserMsg, "The only supported clone() uses are:\n");
531+
VG_(message)(Vg_UserMsg, " - via a threads library (NPTL)\n");
532+
VG_(message)(Vg_UserMsg, " - via the implementation of fork or vfork\n");
533533
VG_(unimplemented)
534534
("Valgrind does not support general clone().");
535535
}

drd/drd_semaphore.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ static void drd_segment_push(struct semaphore_info* p, Segment* sg)
5555
tl_assert(sg);
5656
n = VG_(addToXA)(p->last_sem_post_seg, &sg);
5757
#if 0
58-
VG_(message)(Vg_DebugMsg, "0x%lx push: added at position %ld/%ld",
58+
VG_(message)(Vg_DebugMsg, "0x%lx push: added at position %ld/%ld\n",
5959
p->a1, n, VG_(sizeXA)(p->last_sem_post_seg));
6060
#endif
6161
tl_assert(*(Segment**)VG_(indexXA)(p->last_sem_post_seg, n) == sg);
@@ -69,7 +69,7 @@ static Segment* drd_segment_pop(struct semaphore_info* p)
6969

7070
sz = VG_(sizeXA)(p->last_sem_post_seg);
7171
#if 0
72-
VG_(message)(Vg_DebugMsg, "0x%lx pop: removed from position %ld/%ld",
72+
VG_(message)(Vg_DebugMsg, "0x%lx pop: removed from position %ld/%ld\n",
7373
p->a1, sz - 1, sz);
7474
#endif
7575
sg = 0;

0 commit comments

Comments
 (0)