Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proof Key for Code Exchange Support #99

Open
PeterRodenkirchTNG opened this issue Feb 10, 2023 · 0 comments
Open

Add Proof Key for Code Exchange Support #99

PeterRodenkirchTNG opened this issue Feb 10, 2023 · 0 comments

Comments

@PeterRodenkirchTNG
Copy link

Similar to the issue #243 in the gin-swagger repo, and swaggo/swag#871:

Is your feature request related to a problem? Please describe.
OAuth2 clients that only support Authorization Code Flow with PKCE do not work with the current feature set of echo-swagger.

Describe the solution
Add Proof Key for Code Exchange support. There is a flag for it in Swagger UI 3.24.0+. The flag in Swagger UI is usePkceWithAuthorizationCodeGrant.
In the corresponding Pull Request I added an additional attribute to the OAuthConfig struct called "UsePkce" which configures the boolean parameter for "usePkceWithAuthorizationCodeGrant" in the "initOAuth" part of the index template.
With this small change, the auth flow works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant