const char* vs char*

[jwm-art-net]

wondering if any cleanup could be done regarding the use of char* and the lrdf_statement structs. the char* members are frequently assigned with string literals which cause warnings when compiling. without knowing the code it's not obvious if these members are modified or not.

[swh]

Hm, I'm not sure who's maintaining this code now - Taybin?

I don't remember much about hos this code works, can you point to a file that raises warnings?

[jwm-art-net]

https://github.com/swh/LRDF/blob/master/examples/multi_test.c#L25

[taybin]

I remember going back and forth on this before. I'm not sure why we went with char*. Const seems pretty harmless, but I had a reason. I'll try switching it and seeing if anything complains.

On Dec 19, 2012, at 5:28 AM, Steve Harris [email protected] wrote:

Hm, I'm not sure who's maintaining this code now - Taybin?

I don't remember much about hos this code works, can you point to a file that raises warnings?

—
Reply to this email directly or view it on GitHub.