Skip to content

AsyncHTTPClient calls flush after writing each part of the HTTP message #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adam-fowler opened this issue Apr 22, 2020 · 0 comments · May be fixed by #214
Open

AsyncHTTPClient calls flush after writing each part of the HTTP message #203

adam-fowler opened this issue Apr 22, 2020 · 0 comments · May be fixed by #214
Assignees
@artemredkin
Labels
kind/enhancement Improvements to existing feature.
Milestone
1.2.3

Comments

@adam-fowler
Copy link
Member

Repeatedly calling flush doesn't seem very optimal.

  • HTTPClient.execute calls writeAndFlush and because the body write isn't queued until the head has been written, the flush occurs immediately after the head has been written.
  • TaskHandler.writeBody calls writeAndFlush.

Ideally a simple HTTP request with one ByteBuffer shouldn't need to call flush until after the end part.
@adam-fowler adam-fowler changed the title AsyncHTTPClient calls flush after writing every part of the HTTP message AsyncHTTPClient calls flush after writing each part of the HTTP message Apr 22, 2020
@artemredkin artemredkin self-assigned this May 7, 2020
@artemredkin artemredkin added the kind/enhancement Improvements to existing feature. label May 13, 2020
@artemredkin artemredkin added this to the 1.2.0 milestone May 13, 2020
@artemredkin artemredkin linked a pull request May 18, 2020 that will close this issue
Open
@artemredkin artemredkin modified the milestones: 1.2.0, 1.2.1 Jul 30, 2020
@artemredkin artemredkin modified the milestones: 1.2.1, 1.2.2 Aug 20, 2020
@artemredkin artemredkin modified the milestones: 1.2.2, 1.2.3 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemredkin artemredkin

Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
1.2.3
Development

Successfully merging a pull request may close this issue.

don't flush on every body part artemredkin/async-http-client
2 participants
@artemredkin @adam-fowler