Skip to content

AsyncHTTPClient calls flush after writing each part of the HTTP message #203

Open
@adam-fowler

Description

@adam-fowler

Repeatedly calling flush doesn't seem very optimal.

  • HTTPClient.execute calls writeAndFlush and because the body write isn't queued until the head has been written, the flush occurs immediately after the head has been written.
  • TaskHandler.writeBody calls writeAndFlush.

Ideally a simple HTTP request with one ByteBuffer shouldn't need to call flush until after the end part.

Activity

changed the title [-]AsyncHTTPClient calls flush after writing every part of the HTTP message[/-] [+]AsyncHTTPClient calls flush after writing each part of the HTTP message[/+] on Apr 22, 2020
self-assigned this
on May 7, 2020
added this to the 1.2.0 milestone on May 13, 2020
linked a pull request that will close this issue on May 18, 2020
modified the milestones: 1.2.0, 1.2.1 on Jul 30, 2020
modified the milestones: 1.2.1, 1.2.2 on Aug 20, 2020
modified the milestones: 1.2.2, 1.2.3 on Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/enhancementImprovements to existing feature.

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @artemredkin@adam-fowler

    Issue actions

      AsyncHTTPClient calls flush after writing each part of the HTTP message · Issue #203 · swift-server/async-http-client