add subscripts and deinitializers as documentable Swift symbols

Author: matthewbastien

Sources/SourceKitLSP/Swift/DoccDocumentation.swift

@@ -135,8 +135,12 @@ fileprivate struct DocumentableSymbol {
       self = DocumentableSymbol(node: namedDecl, position: namedDecl.name.positionAfterSkippingLeadingTrivia)
     } else if let initDecl = node.as(InitializerDeclSyntax.self) {
       self = DocumentableSymbol(node: initDecl, position: initDecl.initKeyword.positionAfterSkippingLeadingTrivia)
+    } else if let deinitDecl = node.as(DeinitializerDeclSyntax.self) {
+      self = DocumentableSymbol(node: deinitDecl, position: deinitDecl.deinitKeyword.positionAfterSkippingLeadingTrivia)
     } else if let functionDecl = node.as(FunctionDeclSyntax.self) {
       self = DocumentableSymbol(node: functionDecl, position: functionDecl.name.positionAfterSkippingLeadingTrivia)
+    } else if let subscriptDecl = node.as(SubscriptDeclSyntax.self) {
+      self = DocumentableSymbol(node: subscriptDecl, position: subscriptDecl.positionAfterSkippingLeadingTrivia)
     } else if let variableDecl = node.as(VariableDeclSyntax.self) {
       guard let identifier = variableDecl.bindings.only?.pattern.as(IdentifierPatternSyntax.self) else {
         return nil

Tests/SourceKitLSPTests/DoccDocumentationTests.swift

@@ -116,6 +116,25 @@ final class DoccDocumentationTests: XCTestCase {
     )
   }
 
+  func testSubscriptDeclaration() async throws {
+    try await renderDocumentation(
+      markedText: """
+        /// A structure containing important information.
+        public struct Structure {
+          // Get the 1️⃣subscript at index
+          subscript(in2️⃣dex: Int) -> Int {
+            return i3️⃣ndex
+          }
+        }
+        """,
+      expectedResponses: [
+        "1️⃣": .renderNode(kind: .symbol, path: "test/Structure/subscript(_:)"),
+        "2️⃣": .renderNode(kind: .symbol, path: "test/Structure/subscript(_:)"),
+        "3️⃣": .renderNode(kind: .symbol, path: "test/Structure/subscript(_:)"),
+      ]
+    )
+  }
+
   func testClass() async throws {
     try await renderDocumentation(
       markedText: """
@@ -149,6 +168,25 @@ final class DoccDocumentationTests: XCTestCase {
     )
   }
 
+  func testClassDeInitializer() async throws {
+    try await renderDocumentation(
+      markedText: """
+        /// A class containing important information.
+        public class Class {
+          /// Initi1️⃣alize the class.
+          dein2️⃣it {
+            // De-initi3️⃣alize stuff
+          }
+        }
+        """,
+      expectedResponses: [
+        "1️⃣": .renderNode(kind: .symbol, path: "test/Class/deinit"),
+        "2️⃣": .renderNode(kind: .symbol, path: "test/Class/deinit"),
+        "3️⃣": .renderNode(kind: .symbol, path: "test/Class/deinit"),
+      ]
+    )
+  }
+
   func testEmptyClass() async throws {
     try await renderDocumentation(
       markedText: """