Skip to content

Add flag for building target module graph with experimental feature Embedded #7611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rauhul opened this issue May 29, 2024 · 5 comments
Closed
Labels
embedded Support for Embedded Swift

Comments

@rauhul
Copy link
Member

rauhul commented May 29, 2024

Description

Instead of manually tagging every target you want to build with Embedded, we should add a flag to do this from swift build.

This flag should work in concert with the existing --target and --product options to filter the build graph.

Something like:

$ swift build --product Foo --enable-experimental-feature-Embedded

I propose we do not add a general mechanism for --enable-experimental-feature at this time, as it is unclear to me if that is desirable.

@rauhul rauhul added enhancement embedded Support for Embedded Swift labels May 29, 2024
@MaxDesiatov
Copy link
Contributor

@bnbarham do you think this could be generalized not just for embedded?

@rauhul
Copy link
Member Author

rauhul commented Jun 5, 2024

FWIW we could leave the door more open by parsing --enable-experimental-feature X but only allowing X = Embedded for now

@rauhul
Copy link
Member Author

rauhul commented May 10, 2025

This should now be done with a toolset instead of a top-level SwiftPM build flag. Embedded is a property of a target platform.

@MaxDesiatov
Copy link
Contributor

This should now be done with a toolset instead of a top-level SwiftPM build flag. Embedded is a property of a target platform.

How do you suggest handling empty object files? These can't be handled for the whole object graph in a toolset and still need to be conditionally added per target. Closing this issue seems premature before that problem is resolved.

@rauhul
Copy link
Member Author

rauhul commented May 12, 2025

This should now be done with a toolset instead of a top-level SwiftPM build flag. Embedded is a property of a target platform.

How do you suggest handling empty object files? These can't be handled for the whole object graph in a toolset and still need to be conditionally added per target. Closing this issue seems premature before that problem is resolved.

#8654 should address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded Support for Embedded Swift
Projects
None yet
Development

No branches or pull requests

2 participants