Merge pull request #68221 from nate-chandler/cherrypick/release/5.9.0/rdar114699006

5.9.0: [stdlib] Delete bad @_effects(readonly) annotation

Author: nate-chandler

stdlib/public/core/Dictionary.swift

@@ -821,7 +821,6 @@ extension Dictionary: ExpressibleByDictionaryLiteral {
   /// - Parameter elements: The key-value pairs that will make up the new
   ///   dictionary. Each key in `elements` must be unique.
   @inlinable
-  @_effects(readonly)
   @_semantics("optimize.sil.specialize.generic.size.never")
   public init(dictionaryLiteral elements: (Key, Value)...) {
     let native = _NativeDictionary<Key, Value>(capacity: elements.count)

validation-test/SILOptimizer/rdar114699006.swift

@@ -0,0 +1,38 @@
+// RUN: %target-swift-frontend \
+// RUN:     -primary-file %s   \
+// RUN:     -module-name main  \
+// RUN:     -O                 \
+// RUN:     -g                 \
+// RUN:     -target x86_64-apple-macos10.13 \
+// RUN:     -emit-ir           \
+// RUN:     -o /dev/null       \
+// RUN:     -Xllvm -sil-print-function='$s4main1CCACycfc' \
+// RUN:     2>&1 | %FileCheck %s
+
+// This test expects the stdlib to be in its properly optimized form.
+// REQUIRES: swift_stdlib_no_asserts,optimized_stdlib
+
+// No need to run this test that has a hard-coded target of macos10.13 on other
+// platforms.
+// REQUIRES: OS=macosx
+
+// Verify that after RetainSinking runs, the retain of the __EmptyArrayStorage
+// is _above_ the call to $sSD17dictionaryLiteralSDyxq_Gx_q_td_tcfCSS_SSTg5
+// which consumes the reference.
+// rdar://114699006
+
+// CHECK-LABEL: *** SIL function after {{.*}} RetainSinking (retain-sinking)
+// CHECK-LABEL: sil {{.*}}@$s4main1CCACycfc : {{.*}} {
+// CHECK:         [[REF:%[^,]+]] = raw_pointer_to_ref {{%[^,]+}} : $Builtin.RawPointer to $__EmptyArrayStorage
+// CHECK:         [[BRIDGE_OBJECT:%[^,]+]] = unchecked_ref_cast [[REF]] : $__EmptyArrayStorage to $Builtin.BridgeObject
+// CHECK:         [[BRIDGE_STORAGE:%[^,]+]] = struct $_BridgeStorage<__ContiguousArrayStorageBase> ([[BRIDGE_OBJECT]] :
+// CHECK:         [[ARRAY_BUFFER:%[^,]+]] = struct $_ArrayBuffer<(String, String)> ([[BRIDGE_STORAGE]] :
+// CHECK:         [[ARRAY:%[^,]+]] = struct $Array<(String, String)> ([[ARRAY_BUFFER]] :
+// CHECK:         [[DICTIONARY_INIT:%[^,]+]] = function_ref @$sSD17dictionaryLiteralSDyxq_Gx_q_td_tcfCSS_SSTg5
+// CHECK-NEXT:    strong_retain [[REF]] : $__EmptyArrayStorage
+// CHECK-NEXT:    apply [[DICTIONARY_INIT]]([[ARRAY]], {{.*}})
+// CHECK-LABEL: } // end sil function '$s4main1CCACycfc'
+
+class C {
+    var d: [String : String] = [:]
+}