Merge pull request #81614 from swiftlang/egorzhdan/silverifier-trivial-frt

[cxx-interop] Relax a SILVerifier assertion for immortal reference types

Author: egorzhdan

lib/SIL/Verifier/SILVerifier.cpp

@@ -1059,7 +1059,13 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
 
     auto objectTy = value->getType().unwrapOptionalType();
 
-    require(objectTy.isReferenceCounted(F.getModule()),
+    // Immortal C++ foreign reference types are represented as trivially lowered
+    // types since they do not require retain/release calls.
+    bool isImmortalFRT = objectTy.isForeignReferenceType() &&
+                         objectTy.getASTType()->getReferenceCounting() ==
+                             ReferenceCounting::None;
+
+    require(objectTy.isReferenceCounted(F.getModule()) || isImmortalFRT,
             valueDescription + " must have reference semantics");
   }
 

test/Interop/Cxx/foreign-reference/unmanaged.swift

@@ -0,0 +1,20 @@
+// RUN: %target-run-simple-swift(-I %S/Inputs -cxx-interoperability-mode=default -Xfrontend -disable-availability-checking) | %FileCheck %s
+
+// REQUIRES: executable_test
+
+import POD
+
+extension Empty {
+   public static func == (lhs: Empty, rhs: Empty) -> Bool {
+        Unmanaged.passUnretained(lhs).toOpaque() == Unmanaged.passUnretained(rhs).toOpaque()
+   }
+}
+
+let x = Empty.create()
+let y = Empty.create()
+
+print(x == y)
+// CHECK: false
+
+print(x == x)
+// CHECK: true