Skip to content

Commit 5aa5e3c

Browse files
committed
[test] Enable Serialization/runtime-import-from-sdk on non-Darwin platforms
Also, remove Swift runtime modules from Serialization/module_defining_interface,_client that are unused.
1 parent 5c3faaa commit 5aa5e3c

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

test/Serialization/module_defining_interface.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// RUN: %empty-directory(%t/inputs)
33
// RUN: %empty-directory(%t/test-sdk)
44
// RUN: %empty-directory(%t/test-sdk/usr/lib/swift)
5-
// RUN: cp -r %platform-module-dir/Swift.swiftmodule %t/test-sdk/usr/lib/swift/Swift.swiftmodule
65

76
// RUN: %empty-directory(%t/test-sdk/usr/lib/Foo.swiftmodule)
87
// RUN: split-file %s %t

test/Serialization/module_defining_interface_client.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// RUN: %empty-directory(%t/test-sdk/usr/lib/Bar.swiftmodule)
77
// RUN: %empty-directory(%t/test-sdk/usr/lib/_Foo_Bar.swiftmodule)
88
// RUN: %empty-directory(%t/test-sdk/usr/lib/Foo.swiftcrossimport)
9-
// RUN: cp -r %platform-module-dir/Swift.swiftmodule %t/test-sdk/usr/lib/swift/Swift.swiftmodule
109

1110
// RUN: split-file %s %t
1211

test/Serialization/runtime-import-from-sdk.swift

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@
66

77
// %t/good-sdk contains a loadable standard library.
88
// RUN: %empty-directory(%t/good-sdk)
9-
// RUN: %empty-directory(%t/good-sdk/usr/lib/swift)
9+
// RUN: %empty-directory(%t/good-sdk/usr/lib/swift/%target-sdk-name)
1010
// RUN: cp -r %platform-module-dir/Swift.swiftmodule %t/good-sdk/usr/lib/swift/Swift.swiftmodule
11+
// RUN: cp -r %platform-module-dir/Swift.swiftmodule %t/good-sdk/usr/lib/swift/%target-sdk-name/Swift.swiftmodule
1112

1213
// %t/bad-sdk contains an invalid standard library that cannot be loaded.
1314
// RUN: %empty-directory(%t/bad-sdk)
1415
// RUN: %empty-directory(%t/bad-sdk/usr/lib/swift/Swift.swiftmodule)
16+
// RUN: %empty-directory(%t/bad-sdk/usr/lib/swift/%target-sdk-name/Swift.swiftmodule)
1517
// RUN: touch %t/bad-sdk/usr/lib/swift/Swift.swiftmodule/garbage-garbage-garbage.swiftmodule
18+
// RUN: touch %t/bad-sdk/usr/lib/swift/%target-sdk-name/Swift.swiftmodule/garbage-garbage-garbage.swiftmodule
1619

1720
// %t/empty-toolchain does not contain a standard library.
1821
// RUN: %empty-directory(%t/empty-toolchain)
@@ -45,22 +48,17 @@
4548
// We also check that ClangImporter noticed SwiftShims in the toolchain and
4649
// didn't add a -isystem flag to look in the SDK.
4750

48-
// FIXME: We can't properly test this on a non-Darwin platform because we'll get
49-
// the same error message for "unloadable standard library" and "no standard
50-
// library" (https://github.com/apple/swift/issues/52499).
51-
// REQUIRES: objc_interop
52-
5351
// RUN: %empty-directory(%t/mcp)
5452
// RUN: not %target-swift-frontend(mock-sdk: -sdk %t/bad-sdk) -resource-dir %t/empty-toolchain/usr/lib/swift -module-cache-path %t/mcp -typecheck %s -dump-clang-diagnostics -disable-implicit-concurrency-module-import -disable-implicit-string-processing-module-import 2>&1 | %FileCheck --check-prefix CHECK-EMPTY %s
55-
// CHECK-EMPTY-NOT: '-isystem' '{{.*}}/bad-sdk/usr/lib/swift/shims'
56-
// CHECK-EMPTY: error: could not find module 'Swift' for target '{{.*}}'; found: garbage-garbage-garbage, at: {{.*}}/Swift.swiftmodule
53+
// CHECK-EMPTY-NOT: '-isystem' '{{.*(\\|/)}}bad-sdk{{\\|/}}usr{{\\|/}}lib{{\\|/}}swift{{\\|/}}shims'
54+
// CHECK-EMPTY: error: could not find module 'Swift' for target '{{.*}}'; found: garbage-garbage-garbage, at: {{.*(\\|/)}}Swift.swiftmodule
5755

5856
// Check that, when the toolchain *doesn't* have SwiftShims in it, ClagImporter
5957
// *does* add a -I flag to look in the SDK.
6058

6159
// RUN: %empty-directory(%t/mcp)
6260
// RUN: not %target-swift-frontend(mock-sdk: -sdk %t/bad-sdk) -resource-dir %t/really-empty-toolchain/usr/lib/swift -module-cache-path %t/mcp -typecheck %s -dump-clang-diagnostics -disable-implicit-concurrency-module-import -disable-implicit-string-processing-module-import 2>&1 | %FileCheck --check-prefix CHECK-REALLY-EMPTY %s
63-
// CHECK-REALLY-EMPTY: '-isystem' '{{.*}}/bad-sdk/usr/lib/swift/shims'
64-
// CHECK-REALLY-EMPTY: error: could not find module 'Swift' for target '{{.*}}'; found: garbage-garbage-garbage, at: {{.*}}/Swift.swiftmodule
61+
// CHECK-REALLY-EMPTY: '-isystem' '{{.*(\\|/)}}bad-sdk{{\\|/}}usr{{\\|/}}lib{{\\|/}}swift{{\\|/}}shims'
62+
// CHECK-REALLY-EMPTY: error: could not find module 'Swift' for target '{{.*}}'; found: garbage-garbage-garbage, at: {{.*(\\|/)}}Swift.swiftmodule
6563

6664
let x: Int = 1

0 commit comments

Comments
 (0)