Skip to content

[SR-10536] update-checkout gives useless spew if git clone fails or it's not in a checkout #52936

Open
@rjmccall

Description

@rjmccall
Previous ID SR-10536
Radar None
Original Reporter @rjmccall
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, UpdateCheckout
Assignee None
Priority Medium

md5: 343b94f6b2614a0d4122a502c9976a97

Issue Description:

I've noticed in the past that update-checkout gives terrible "diagnostics" if `git clone` fails: basically, it just crashes and lets Python print its normal exception stacktrace, which is really difficult to find useful information in (even for me, much less someone who doesn't know what to look for). It also seems to fail quite badly if it's not in a checkout directory, e.g. if someone's trying to build from a source tarball; we don't necessarily need to support that, but we should give more useful feedback than a Python exception.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA deviation from expected or documented behavior. Also: expected but undesirable behavior.compilerThe Swift compiler itselfupdate-checkoutArea → utils: the `update-checkout` script

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions