Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pulling sources from compiler into runtimes #77462

Open
etcwilde opened this issue Nov 7, 2024 · 1 comment
Open

Stop pulling sources from compiler into runtimes #77462

etcwilde opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
cmake runtime The Swift Runtime task triage needed This issue needs more specific labels

Comments

@etcwilde
Copy link
Contributor

etcwilde commented Nov 7, 2024

Description

Several libraries in the Swift runtimes pull sources from the compiler into the runtime libraries.
This is bad since we want to carefully control what is pulled into the runtime libraries for ABI and API purposes.

Libraries pulling headers from the compiler:

  • SwiftStdlibStubs
  • runtime
  • Demangling
  • CommandLineSupport
  • Threadings

Libraries pulling sources from the compiler:

  • Demangling
  • Threading
  • runtime (ThreadSanitizer.cpp)

These are the bits just going into swiftCore that I've noticed crossing the boundary.

Additional information

No response

@etcwilde etcwilde added task runtime The Swift Runtime cmake triage needed This issue needs more specific labels labels Nov 7, 2024
@etcwilde etcwilde self-assigned this Nov 7, 2024
@etcwilde
Copy link
Contributor Author

etcwilde commented Nov 7, 2024

The ELF swiftrt.o also pulls headers from the compiler source directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake runtime The Swift Runtime task triage needed This issue needs more specific labels
Projects
None yet
Development

No branches or pull requests

1 participant