Skip to content

Commit 1ac847f

Browse files
authored
Bump to Node 20.19 (#1569)
Match vscode's new node version
1 parent 0fc9605 commit 1ac847f

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ RUN export DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true \
1313

1414
RUN mkdir -p /usr/local/nvm
1515
ENV NVM_DIR /usr/local/nvm
16-
ENV NODE_VERSION v20.18.2
16+
ENV NODE_VERSION v20.19.0
1717
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
1818
RUN /bin/bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
1919
ENV NODE_PATH $NVM_DIR/versions/node/$NODE_VERSION/bin

.github/workflows/nightly.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ jobs:
1818
uses: actions/checkout@v4
1919
- name: Build Extension
2020
run: |
21-
export NODE_VERSION=v20.18.2
22-
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
21+
export NODE_VERSION=v20.19.0
22+
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
2323
export NVM_DIR=/usr/local/nvm
2424
. .github/workflows/scripts/setup-linux.sh
2525
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
@@ -53,8 +53,8 @@ jobs:
5353
needs_token: true
5454
# Linux
5555
linux_env_vars: |
56-
NODE_VERSION=v20.18.2
57-
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
56+
NODE_VERSION=v20.19.0
57+
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
5858
NVM_DIR=/usr/local/nvm
5959
CI=1
6060
VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
@@ -80,8 +80,8 @@ jobs:
8080
# Linux
8181
linux_exclude_swift_versions: '[{"swift_version": "5.8"}, {"swift_version": "5.9"}, {"swift_version": "5.10"}, {"swift_version": "6.0"}, {"swift_version": "nightly-6.1"}, {"swift_version": "nightly-main"}]'
8282
linux_env_vars: |
83-
NODE_VERSION=v20.18.2
84-
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
83+
NODE_VERSION=v20.19.0
84+
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
8585
NVM_DIR=/usr/local/nvm
8686
CI=1
8787
VSCODE_VERSION=insiders

.github/workflows/pull_request.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ jobs:
1717
uses: actions/checkout@v4
1818
- name: Build Extension
1919
run: |
20-
export NODE_VERSION=v20.18.2
21-
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
20+
export NODE_VERSION=v20.19.0
21+
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
2222
export NVM_DIR=/usr/local/nvm
2323
. .github/workflows/scripts/setup-linux.sh
2424
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
@@ -50,8 +50,8 @@ jobs:
5050
# Linux
5151
linux_exclude_swift_versions: '[{"swift_version": "nightly-6.1"},{"swift_version": "nightly-main"}]'
5252
linux_env_vars: |
53-
NODE_VERSION=v20.18.2
54-
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
53+
NODE_VERSION=v20.19.0
54+
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
5555
NVM_DIR=/usr/local/nvm
5656
CI=1
5757
FAST_TEST_RUN=${{ contains(github.event.pull_request.labels.*.name, 'full-test-run') && '0' || '1'}}

.github/workflows/scripts/setup-linux.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
##
1414
##===----------------------------------------------------------------------===##
1515

16-
export NODE_VERSION=v20.18.2
17-
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
16+
export NODE_VERSION=v20.19.0
17+
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
1818
export NVM_DIR=/usr/local/nvm
1919

2020
apt-get update && apt-get install -y rsync curl gpg libasound2 libgbm1 libgtk-3-0 libnss3 xvfb build-essential

.github/workflows/scripts/windows/install-nodejs.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
$NODEJS='https://nodejs.org/dist/v20.18.2/node-v20.18.2-x64.msi'
1+
$NODEJS='https://nodejs.org/dist/v20.19.0/node-v20.19.0-x64.msi'
22
$NODEJS_SHA256='c2654d3557abd59de08474c6dd009b1d358f420b8e4010e4debbf130b1dfb90a'
33
Set-Variable ErrorActionPreference Stop
44
Set-Variable ProgressPreference SilentlyContinue

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20.18.2
1+
20.19.0

0 commit comments

Comments
 (0)