Skip to content

Commit 7c7072f

Browse files
committed
build(CMakeLists): dynamic link to libcap by default
This is a only exception while all other libraries are dynamically linked. The "TODO" does not make any sense as libcap provides both dynamic and static libraries. There is not reason to explain why it needs to be statically linked 'especially' as dynamic linking works very well. Then just make it dynamically-linked by default, which also matches the behaviour on autotools. Compiled and tested on aarch64, no errors found. Signed-off-by: Tianling Shen <[email protected]>
1 parent ba8855f commit 7c7072f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@ if(N2N_OPTION_USE_ZSTD)
238238
endif(N2N_OPTION_USE_ZSTD)
239239

240240
if(N2N_OPTION_USE_CAPLIB)
241-
# TODO: this is a static library, shouldnt we have a generic one?
242-
target_link_libraries(edge cap.a)
241+
target_link_libraries(edge cap)
243242
endif(N2N_OPTION_USE_CAPLIB)
244243

245244
if(N2N_OPTION_USE_PORTMAPPING)

0 commit comments

Comments
 (0)