Skip to content

Commit bacb368

Browse files
committed
iterate
1 parent 6fbce06 commit bacb368

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

.github/workflows/.utils.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ export -f _run_task
3131

3232
install_property_info_for_version() {
3333
local php_version="$1"
34-
local min_stability="$2"
34+
local symfony_version="$2"
35+
local min_stability="$3"
3536
local dependency_version="$3"
3637

37-
if [ "$dependency_version" = "lowest" ]; then
38+
if [ "$dependency_version" = "lowest" ] || [ "$symfony_version" = "6.4.*" ]; then
3839
# Prevent usage of TypeInfo, required to test support of LegacyLivePropMetadata
3940
composer require symfony/property-info:6.4.*
4041
elif [ "$php_version" = "8.2" ] ; then

.github/workflows/unit-tests.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,23 @@ jobs:
3737
# dev packages (probably not needed to have multiple such jobs)
3838
- minimum-stability: 'dev'
3939
php-version: '8.4'
40+
4041
# lowest deps
4142
- php-version: '8.2'
4243
dependency-version: 'lowest'
43-
# LTS version of Symfony
44-
- php-version: '8.2'
45-
symfony-version: '6.4.*'
46-
- php-version: '8.2'
47-
symfony-version: '6.4.*'
48-
os: 'windows-latest'
49-
# Explicit Symfony versions
44+
45+
# oldest LTS
5046
- php-version: '8.2'
5147
symfony-version: '6.4.*'
48+
49+
# oldest LTS + Windows
50+
- php-version: '8.2'
51+
symfony-version: '6.4.*'
52+
os: 'windows-latest'
53+
5254
- php-version: '8.2'
5355
symfony-version: '7.3.*' # TODO: change to '7.4' when Symfony 7.4 is released
56+
5457
- php-version: '8.4'
5558
symfony-version: '8.0.x-dev' # TODO: change to '8.0' when Symfony 8.0 is released
5659
minimum-stability: 'dev' # TODO: remove when Symfony 8.0 is released
@@ -111,7 +114,7 @@ jobs:
111114
'(cd src/{} \
112115
&& $COMPOSER_MIN_STAB \
113116
&& $COMPOSER_UP \
114-
&& if [ {} = LiveComponent ]; then install_property_info_for_version \"${{ matrix.php-version }}\" \"${{ matrix.minimum-stability }}\" \"${{ matrix.dependency-version }}\"; fi \
117+
&& if [ {} = LiveComponent ]; then install_property_info_for_version \"${{ matrix.php-version }}\" \"${{ matrix.symfony-version }}\" \"${{ matrix.minimum-stability }}\" \"${{ matrix.dependency-version }}\"; fi \
115118
&& $PHPUNIT)'"
116119
117120
- name: Run packages tests (Windows)

0 commit comments

Comments
 (0)