🌱 Explain the fork in the README. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
force-pushed
the
tg/explain-fork-in-readme
branch
2 times, most recently
from
c5e94a3 to
d689e5c
Compare
guettli
force-pushed
the
tg/explain-fork-in-readme
branch
from
d689e5c to
4800a8a
Compare
janiskemper
reviewed
Dec 13, 2024
There was a problem hiding this comment.
this looks like a lot of work was put in. Thanks @guettli . I cannot really review all the details of the lists you created though. If that is not a problem, I can also approve.
If someone is able to actually validate it, then that person should do it instead.
go.mod
Outdated
| k8s.io/component-base v0.28.2 | ||
| k8s.io/klog/v2 v2.100.1 | ||
| k8s.io/kubectl v0.27.2 | ||
| k8s.io/api v0.32.0 |
There was a problem hiding this comment.
we shouldn't have this on 0.32. It should be always in line with CAPI because otherwise we will have difficulties with updates.
This will probably not happen here, because we don't import it as library, but still a good practice IMO
There was a problem hiding this comment.
@janiskemper I downgraded to k8s.io/api v0.30.3.
Anything else? If not, please approve the PR.
janiskemper
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the fork in the README.
See "About the Fork": https://github.com/syself/hetzner-cloud-controller-manager/blob/tg/explain-fork-in-readme/README.md