Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build proxysql packages with version tagged docker image #4604

Open
mirostauder opened this issue Aug 12, 2024 · 2 comments
Open

Build proxysql packages with version tagged docker image #4604

mirostauder opened this issue Aug 12, 2024 · 2 comments

Comments

@mirostauder
Copy link
Collaborator

mirostauder commented Aug 12, 2024

docker images proxysql/packaging are being tagged with a version since v2.5.3 release
https://hub.docker.com/r/proxysql/packaging/tags?page=2&page_size=&ordering=&name=2.5.3

Currently (as of v2.6.3) for package building, an image without a version tag is used (the latest), this hurts reproducible builds and leads to issues when building other versions.

Make sure a ProxySQL packages are built with the correct proxysql/packaging image
add a variable IMGVER based on CURVER, to specify the version.

https://github.com/sysown/proxysql/blob/01d1fc9828a5da09896acd2287be48335bbc1ada/Makefile#L38C16-L39C1

e.g.

CURVER=2.6.3
IMGVER=2.6.3

will use proxysql/packaging images tagged with 2.6.3
https://hub.docker.com/r/proxysql/packaging/tags?page=2&page_size=&ordering=&name=2.6.3

@renecannao
Copy link
Contributor

Thinking ...
It is even possible that different package images are updated at different times, for example we may need to update for a specific OS and not for other.
Maybe the tag should be on a per-distro basis, thus defined in the docker-compose file .

@mirostauder
Copy link
Collaborator Author

implemented in PR #4617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants