Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a test for recognizing backwards parenthesis with hebrew #174

Open
RonStrauss opened this issue Jun 23, 2023 · 1 comment
Open

Write a test for recognizing backwards parenthesis with hebrew #174

RonStrauss opened this issue Jun 23, 2023 · 1 comment

Comments

@RonStrauss
Copy link
Contributor

RonStrauss commented Jun 23, 2023

I tried looking up backwards parenthesis next to hebrew letters, and I came up with the following regex:
\)(?=[\u0590-\u05FF])

Would a precommit test that validates certain common, easy to find, typos be worthwhile?

I've fixed tonly one I've found so far. #173

@RonStrauss RonStrauss mentioned this issue Jun 23, 2023
@szabgab
Copy link
Owner

szabgab commented Jun 23, 2023

I don't have pre-commits, but adding it to the CI that runs on GitHub would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants