Add support for derive Into<Target>
#164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is supported. I think it just needs to do the same thing as any other core::convert traits: https://github.com/taiki-e/auto_enums/blob/main/src/derive/core/convert.rs |
|
You're right, I was too focused on doing I tried that approach with great success regarding codegen. but no success regarding compilation #[auto_enum(Into)]
fn a(x: u8) -> impl Into<u64> {
match x {
0 => 8_u8,
1 => 16_u16,
2 => 32_u32,
_ => false
}
}generates fn a(x: u8) -> impl Into<u64> {
#[allow(non_camel_case_types)]
enum __Enum6219237852123227426<__Variant0, __Variant1, __Variant2, __Variant3> {
__Variant0(__Variant0),
__Variant1(__Variant1),
__Variant2(__Variant2),
__Variant3(__Variant3),
}
#[automatically_derived]
impl<__Variant0, __Variant1, __Variant2, __Variant3, __T> ::core::convert::Into<__T>
for __Enum6219237852123227426<__Variant0, __Variant1, __Variant2, __Variant3>
where
__Variant0: ::core::convert::Into<__T>,
__Variant1: ::core::convert::Into<__T>,
__Variant2: ::core::convert::Into<__T>,
__Variant3: ::core::convert::Into<__T>,
{
#[inline]
fn into(self) -> __T {
match self {
__Enum6219237852123227426::__Variant0(x) => {
<__Variant0 as ::core::convert::Into<__T>>::into(x)
}
__Enum6219237852123227426::__Variant1(x) => {
<__Variant1 as ::core::convert::Into<__T>>::into(x)
}
__Enum6219237852123227426::__Variant2(x) => {
<__Variant2 as ::core::convert::Into<__T>>::into(x)
}
__Enum6219237852123227426::__Variant3(x) => {
<__Variant3 as ::core::convert::Into<__T>>::into(x)
}
}
}
}
match x {
0 => __Enum6219237852123227426::__Variant0(8_u8),
1 => __Enum6219237852123227426::__Variant1(16_u16),
2 => __Enum6219237852123227426::__Variant2(32_u32),
_ => __Enum6219237852123227426::__Variant3(false),
}
}Which triggers a compile error Because the enum itself could replace On a nicer note this experimentation gave me hope for a used code genpub(crate) mod into {
use crate::derive::prelude::*;
pub(crate) const NAME: &[&str] = &["Into"];
pub(crate) fn derive(_cx: &Context, data: &Data) -> Result<TokenStream> {
Ok(derive_trait(data, &parse_quote!(::core::convert::Into), None, parse_quote! {
trait Into<__T> {
#[inline]
fn into(self) -> __T;
}
}))
}
} |
vic1707
force-pushed
the
add-into-derive
branch
3 times, most recently
from
89732f8 to
7a1ac6a
Compare
vic1707
force-pushed
the
add-into-derive
branch
from
7a1ac6a to
d25c91a
Compare
vic1707
force-pushed
the
add-into-derive
branch
5 times, most recently
from
beeab47 to
6d9f3ee
Compare
vic1707
force-pushed
the
add-into-derive
branch
from
c51fff7 to
84d6d31
Compare
vic1707
force-pushed
the
add-into-derive
branch
from
84d6d31 to
8754724
Compare
|
Still need to update the changelog and see if i missed some docs but the implementation looks good to me |
|
Out of curiosity I tried a fn a(x: u8) -> impl Into<u64> {
enum __Enum6219237852123227426<
__Variant0,
__Variant1,
__Variant2,
__Variant3,
> {
__Variant0(__Variant0),
__Variant1(__Variant1),
__Variant2(__Variant2),
__Variant3(__Variant3),
}
impl<__Variant0, __Variant1, __Variant2, __Variant3, __T>
::core::convert::From<
__Enum6219237852123227426<
__Variant0,
__Variant1,
__Variant2,
__Variant3,
>,
> for __T
where
__T: ::core::convert::From<__Variant0>,
__T: ::core::convert::From<__Variant1>,
__T: ::core::convert::From<__Variant2>,
__T: ::core::convert::From<__Variant3>,
{
#[inline]
fn from(
enum_value: __Enum6219237852123227426<
__Variant0,
__Variant1,
__Variant2,
__Variant3,
>,
) -> __T {
match enum_value {
__Enum6219237852123227426::__Variant0(x) => x.into(),
__Enum6219237852123227426::__Variant1(x) => x.into(),
__Enum6219237852123227426::__Variant2(x) => x.into(),
__Enum6219237852123227426::__Variant3(x) => x.into(),
}
}
}
match x {
0 => __Enum6219237852123227426::__Variant0(8_u8),
1 => __Enum6219237852123227426::__Variant1(16_u16),
2 => __Enum6219237852123227426::__Variant2(32_u32),
_ => __Enum6219237852123227426::__Variant3(false),
}
}
fn main() {
let a: u64 = a(12).into();
println!("{a}");
}But this seems to make rustc go crazy as I never get any compile error but also no program, no compilation, rust-analyzer is also unresponsive xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Currently a WIP, the implementation works but isn't pretty nor clean.
Refactor in progress, mostly moving code around, adding the feature gate, add tests, remove the
'convert'as a default featureetc...
If you already have suggestions @taiki-e I'll gladly read them !
Especially around the manual use of
derive_utils::EnumImpl, I thinkderive_utilsdoesn't handle generic traits for now right ?