Skip to content

Commit b40fc1f

Browse files
authored
fix(codegen): import java.util.List when using nullableHelpers (#34)
1 parent b9b3d0c commit b40fc1f

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

internal/codegen/common.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ type nullableHelper struct {
4242
ArgType string
4343
}
4444

45-
func (b *IndentStringBuilder) writeNullableHelpers(nullableHelpers core.NullableHelpers, nonNullAnnotation, nullableAnnotation string) {
45+
func (b *IndentStringBuilder) writeNullableHelpers(nullableHelpers core.NullableHelpers, nonNullAnnotation, nullableAnnotation string) []string {
46+
imports := make([]string, 0)
4647
methodTypes := []nullableHelper{
4748
{nullableHelpers.Int, "Integer", "Int"},
4849
{nullableHelpers.Long, "Long", "Long"},
@@ -77,7 +78,11 @@ func (b *IndentStringBuilder) writeNullableHelpers(nullableHelpers core.Nullable
7778
))
7879
b.WriteIndentedString(2, "var colVal = rs.getArray(col); return colVal == null ? null : Arrays.asList(as.cast(colVal.getArray()));\n")
7980
b.WriteIndentedString(1, "}\n")
81+
82+
imports = append(imports, "java.util.List")
8083
}
84+
85+
return imports
8186
}
8287

8388
func (b *IndentStringBuilder) writeParameter(javaType core.JavaType, name, nonNullAnnotation, nullableAnnotation string) ([]string, error) {

internal/codegen/queries.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,9 @@ func BuildQueriesFile(engine string, config core.Config, queryFilename string, q
162162

163163
// boilerplate methods to allow for getting null primitive values
164164
body.WriteString("\n")
165-
body.writeNullableHelpers(nullableHelpers, nonNullAnnotation, nullableAnnotation)
165+
166+
imp := body.writeNullableHelpers(nullableHelpers, nonNullAnnotation, nullableAnnotation)
167+
imports = append(imports, imp...)
166168

167169
for _, q := range queries {
168170
body.WriteString("\n")

0 commit comments

Comments
 (0)