Build the project for MSVC with 'W3 /WX' compile option

MSVC's W3 option displays (production quality) warnings
The WX means error if a warning is encountered

Author: Allen Winter

CMakeLists.txt

@@ -323,11 +323,14 @@ if(WIN32)
     if(USE_32BIT_TIME_T)
       add_definitions(-D_USE_32BIT_TIME_T)
     endif()
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W3 /WX")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W3 /WX")
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4211") #allow redefine extern as static
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4290") #C++ exception specification ignored
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4068") #unknown pragma
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4028") #formal parameter differs
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4068") #unknown pragma
+
   endif()
   add_definitions(-DBIG_ENDIAN=0 -DLITTLE_ENDIAN=1 -DBYTE_ORDER=BIG_ENDIAN)
 endif()

config.h.cmake

@@ -428,8 +428,12 @@ typedef unsigned int wint_t;
 /* read - system function to read from a file descriptor */
 #if defined(HAVE__READ)
 #include <io.h>
+#if defined(__cplusplus)
 #define read _read
 #else
+#define read(a, b, c) _read((a), (b), (unsigned)(c))
+#endif
+#else
 #if !defined(HAVE_READ)
 #error "No read from file descriptor system function available"
 #else
@@ -442,8 +446,12 @@ typedef unsigned int wint_t;
 /* write - system function to write to a file descriptor */
 #if defined(HAVE__WRITE)
 #include <io.h>
+#if defined(__cplusplus)
 #define write _write
 #else
+#define write(a, b, c) _write((a), (b), (unsigned int)(c))
+#endif
+#else
 #if !defined(HAVE_WRITE)
 #error "No write to file descriptor system function available"
 #else

src/libical/icalvalue.c

@@ -375,7 +375,7 @@ static int simple_str_to_doublestr(const char *from, char *result, int result_le
         ++cur;
     }
     end = cur;
-    len = end - start;
+    len = (int)(ptrdiff_t)(end - start);
     if (len + 1 >= result_len) {
         /* huh hoh, number is too big. truncate it */
         len = result_len - 1;

src/libicalvcard/CMakeLists.txt

@@ -179,12 +179,6 @@ target_link_libraries(
   icalvcard ical
 )
 
-if(MSVC)
-  target_compile_options(icalvcard PRIVATE /W4 /WX)
-else()
-  target_compile_options(icalvcard PRIVATE -Wall -Wextra -Werror)
-endif()
-
 if(MSVC)
   set_target_properties(icalvcard PROPERTIES PREFIX "lib")
   if(NOT SHARED_ONLY AND NOT STATIC_ONLY)

src/test/vcf_leak.cpp

@@ -46,7 +46,7 @@ int main(int argc, char *argv[])
     }
 
     using vcardptr = std::unique_ptr<VObject, decltype(&cleanVObject)>;
-    vcardptr ptr(Parse_MIME((char *)content.c_str(), content.size()), cleanVObject);
+    vcardptr ptr(Parse_MIME((char *)content.c_str(), static_cast<unsigned long>(content.size())), cleanVObject);
 
     return 0;
 }