Xref to examples don't include clause name when it's in the same clause.

tc39 · Aug 20, 2015 · acf7fed · acf7fed
1 parent 874e55d
commit acf7fed
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/lib/Xref.js b/lib/Xref.js
@@ -1,5 +1,6 @@
 'use strict';
 const Builder = require('./Builder');
+const utils = require('./utils');
 
 module.exports = class Xref extends Builder {
   build() {
@@ -94,10 +95,15 @@ function buildExampleLink(spec, xref, entry) {
       console.log('Warning: could not find parent clause for example id ' + entry.id);
     }
 
-    if (xref.hasAttribute('title')) {
-      xref.innerHTML = buildXrefLink(entry, clauseEntry.entry.title + ' Example ' + entry.number);
+    const parentClause = utils.parent(xref, ['EMU-CLAUSE', 'EMU-INTRO', 'EMU-ANNEX']);
+    if (parentClause && parentClause.id === clauseEntry.entry.id) {
+      xref.innerHTML = buildXrefLink(entry, 'Example ' + entry.number);
     } else {
-      xref.innerHTML = buildXrefLink(entry, clauseEntry.entry.number + ' Example ' + entry.number);
+      if (xref.hasAttribute('title')) {
+        xref.innerHTML = buildXrefLink(entry, clauseEntry.entry.title + ' Example ' + entry.number);
+      } else {
+        xref.innerHTML = buildXrefLink(entry, clauseEntry.entry.number + ' Example ' + entry.number);
+      }
     }
   } else {
     xref.innerHTML = buildXrefLink(entry, xref.innerHTML);

diff --git a/test/xref.html b/test/xref.html
@@ -35,7 +35,8 @@ <h1>Clause Title</h1>
 
   <!-- refs to examples -->
   <emu-xref href="#example-2"></emu-xref>
-  <emu-xref href="#example-1" title></emu-xref>
+  <emu-xref href="#example-1"></emu-xref> <!-- examples in current clause shouldn't include clause name -->
+  <emu-xref href="#example-1" title></emu-xref> <!-- examples in current clause shouldn't include clause name -->
   <emu-xref href="#example-3" title></emu-xref>
   <emu-xref href="#example-2">with link text</emu-xref>
 

diff --git a/test/xref.html.baseline b/test/xref.html.baseline
@@ -36,7 +36,8 @@
 
   <!-- refs to examples -->
   <emu-xref href="#example-2"><a href="#example-2">1.1 Example 1</a></emu-xref>
-  <emu-xref href="#example-1" title=""><a href="#example-1">Clause Title Example 1</a></emu-xref>
+  <emu-xref href="#example-1"><a href="#example-1">Example 1</a></emu-xref> <!-- examples in current clause shouldn't include clause name -->
+  <emu-xref href="#example-1" title=""><a href="#example-1">Example 1</a></emu-xref> <!-- examples in current clause shouldn't include clause name -->
   <emu-xref href="#example-3" title=""><a href="#example-3">AbstractOp Example 2</a></emu-xref>
   <emu-xref href="#example-2"><a href="#example-2">with link text</a></emu-xref>