Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support costom note types #636

Open
nicolo-ribaudo opened this issue Mar 7, 2025 · 0 comments
Open

Support costom note types #636

nicolo-ribaudo opened this issue Mar 7, 2025 · 0 comments

Comments

@nicolo-ribaudo
Copy link
Member

In ECMA-426, we have more types of "notes" than the two supported by ecmarkup. For example, in http://tc39.es/ecma426/#sec-linking-inline you can see an "Example" and an "Issue".

We currently make them work by using <emu-note example>/<emu-note issue> with some custom CSS, but we have to inject the "Example"/"Issue" title through CSS so it's not user-selectable.

It'd be great if Ecmarkup:

  1. allowed custom values for emu-note's type attribute, and used it to generate the label and to maintain the counter, type="editor" would be special-cased to have "editor's note" rather than just "editor" as the label
  2. the various colors were customizable through CSS variables, so that we could simply do
    emu-note[type=example] {
      --note-text-color: #574b0f;
      --note-border-color: #e0cb52;
      --note-background-color: #fcfaee;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant