Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar cleanup #4

Closed
waldemarhorwat opened this issue Apr 5, 2024 · 1 comment
Closed

Grammar cleanup #4

waldemarhorwat opened this issue Apr 5, 2024 · 1 comment

Comments

@waldemarhorwat
Copy link

A stylistic nit:

Is there a reason the BindingPattern has the extra parameter void? The cleaner and simpler approach would seem to be to leave BindingPattern as is and introduce a new BindingPatternOrVoid production which expands to either BindingPattern or void, but I'm not sure if there is some future planned consideration that I'm overlooking. I originally created the notion of parameters on grammar productions to avoid duplicating a deep tree of productions, which doesn't apply here.

Also, where can I find the base grammar that this one is a difference of?

@rbuckton
Copy link
Collaborator

I believe this was addressed by #9 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants