-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfill: Hour cycle not correctly set when defaults are used #3065
Comments
Thanks for pointing this out. I guess it's locale-dependent whether the first line of the expected results should have I'll submit a PR to make the reference code conform to the spec. However, clearly this was a gap in test262 coverage since it wasn't caught before, so I've added the test262 label to this issue and will keep it open. We should have coverage for PlainTime, PlainDateTime, Instant, and ZonedDateTime formatting. |
The second line, for |
The strategy of caching the output of DTF resolvedOptions() failed in the case of hour12/hourCycle, because those options are silently dropped if the chosen format does not include an hour component. Manually add them to the cached resolvedOptions object if the user included them. See: #3065
The strategy of caching the output of DTF resolvedOptions() failed in the case of hour12/hourCycle, because those options are silently dropped if the chosen format does not include an hour component. Manually add them to the cached resolvedOptions object if the user included them. See: #3065
The strategy of caching the output of DTF resolvedOptions() failed in the case of hour12/hourCycle, because those options are silently dropped if the chosen format does not include an hour component. Manually add them to the cached resolvedOptions object if the user included them. See: #3065
Test case:
Actual:
Expected:
The text was updated successfully, but these errors were encountered: