Skip to content

Commit

Permalink
feat: enable stepactions by default
Browse files Browse the repository at this point in the history
  • Loading branch information
waveywaves committed Feb 20, 2025
1 parent 22b6d55 commit 8e88907
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
6 changes: 3 additions & 3 deletions config/config-feature-flags.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ data:
keep-pod-on-cancel: "false"
# Setting this flag to "true" will enable the CEL evaluation in WhenExpression
enable-cel-in-whenexpression: "false"
# Setting this flag to "true" will enable the use of StepActions in Steps
# This feature is in preview mode and not implemented yet. Please check #7259 for updates.
enable-step-actions: "false"
# Setting this flag to "true" will enable the use of StepActions in Steps.
# This is a stable feature.
enable-step-actions: "true"
# Setting this flag to "true" will enable the use of Artifacts in Steps
# This feature is in preview mode and not implemented yet. Please check #7693 for updates.
enable-artifacts: "false"
Expand Down
2 changes: 1 addition & 1 deletion docs/stepactions.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ weight: 201

## Overview
> :seedling: **`StepActions` is an [beta](additional-configs.md#beta-features) feature.**
> The `enable-step-actions` feature flag must be set to `"true"` to specify a `StepAction` in a `Step`.
> Step actions are enabled by default. You can disable them by setting the `enable-step-actions` feature flag to `"false"`.
A `StepAction` is the reusable and scriptable unit of work that is performed by a `Step`.

Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/config/feature_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ var (
// DefaultEnableStepActions is the default PerFeatureFlag value for EnableStepActions
DefaultEnableStepActions = PerFeatureFlag{
Name: EnableStepActions,
Stability: BetaAPIFields,
Enabled: DefaultBetaFeatureEnabled,
Stability: StableAPIFields,
Enabled: DefaultStableFeatureEnabled,
}

// DefaultEnableArtifacts is the default PerFeatureFlag value for EnableArtifacts
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/config/feature_flags_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
SetSecurityContext: config.DefaultSetSecurityContext,
Coschedule: config.DefaultCoschedule,
EnableParamEnum: config.DefaultEnableParamEnum.Enabled,
EnableStepActions: config.DefaultEnableStepActions.Enabled,
DisableInlineSpec: config.DefaultDisableInlineSpec,
},
fileName: "feature-flags-bundles-and-custom-tasks",
Expand All @@ -152,6 +153,7 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
SetSecurityContext: config.DefaultSetSecurityContext,
Coschedule: config.DefaultCoschedule,
EnableParamEnum: config.DefaultEnableParamEnum.Enabled,
EnableStepActions: config.DefaultEnableStepActions.Enabled,
DisableInlineSpec: config.DefaultDisableInlineSpec,
},
fileName: "feature-flags-beta-api-fields",
Expand Down
3 changes: 2 additions & 1 deletion pkg/apis/config/testdata/feature-flags-beta-api-fields.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ metadata:
name: feature-flags
namespace: tekton-pipelines
data:
enable-api-fields: "beta"
enable-api-fields: "beta"
enable-step-actions: "true"
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ data:
enable-tekton-oci-bundles: "true"
enable-custom-tasks: "true"
enable-api-fields: "stable"
enable-step-actions: "true"

0 comments on commit 8e88907

Please sign in to comment.