Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable step actions by default #8546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enable step actions by default #8546

wants to merge 1 commit into from
+15 −9

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Jan 31, 2025 •
edited
Loading

Changes

partially fixes #8485

enable using step actions out of the box for tekton-pipelines

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 31, 2025
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2025
@tekton-robot tekton-robot requested review from abayer and jerop January 31, 2025 16:47
@waveywaves waveywaves marked this pull request as ready for review January 31, 2025 16:51
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@waveywaves
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2025
l-qing
l-qing reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@l-qing l-qing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any TEP documents or checklists to determine if the feature meets beta maturity?

@waveywaves
Copy link
Member Author

@l-qing the current tracker I am following is #8485

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from ed246ea to 405e8ed Compare February 12, 2025 18:58
@waveywaves
Copy link
Member Author

cc @vdemeester

@tekton-robot
Copy link
Collaborator

@waveywaves: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests 405e8ed link true /test pull-tekton-pipeline-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 2 times, most recently from 95ffb3a to 845dd31 Compare February 19, 2025 21:59
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 845dd31 to a45de74 Compare February 19, 2025 22:04
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from a45de74 to d4a5306 Compare February 19, 2025 22:05
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from d4a5306 to 3fa0ffa Compare February 19, 2025 22:34
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 2 times, most recently from 723d69a to 8e88907 Compare February 20, 2025 15:56
@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

@waveywaves it might need a rebase 🙃

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 8e88907 to 163221d Compare February 25, 2025 11:00
@waveywaves waveywaves closed this Feb 26, 2025
@waveywaves waveywaves reopened this Feb 26, 2025
@waveywaves waveywaves closed this Feb 26, 2025
@waveywaves waveywaves reopened this Feb 26, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 2 times, most recently from 8e7d285 to 9ce2a13 Compare February 26, 2025 13:52
@vdemeester
Copy link
Member

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l-qing, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 9ce2a13 to 6c8346e Compare February 27, 2025 11:53
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 86.1% 83.9% -2.2

@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch 3 times, most recently from 5b272f5 to 72f3927 Compare February 27, 2025 13:12
@waveywaves waveywaves force-pushed the feat/stepactions-enabled-default branch from 72f3927 to 0ed96bf Compare February 27, 2025 13:13
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 86.1% 83.9% -2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@l-qing l-qing l-qing approved these changes

@abayer abayer Awaiting requested review from abayer

@jerop jerop Awaiting requested review from jerop

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TEP-0142 Promote StepActions to GA
4 participants
@waveywaves @tekton-robot @vdemeester @l-qing