tensorflow_datasets/testing remove TODOs

Author: vijayphoenix

tensorflow_datasets/testing/dataset_builder_testing.py

@@ -239,7 +239,7 @@ def _make_builder(self, config=None):
 
   @test_utils.run_in_graph_and_eager_modes()
   def test_download_and_prepare_as_dataset(self):
-    """ __TODO__ """
+    """ Test _download_and_prepare_as_dataset """
     # If configs specified, ensure they are all valid
     if self.BUILDER_CONFIG_NAMES_TO_TEST:
       for config in self.BUILDER_CONFIG_NAMES_TO_TEST:  # pylint: disable=not-an-iterable
@@ -264,7 +264,7 @@ def test_download_and_prepare_as_dataset(self):
       self._download_and_prepare_as_dataset(self.builder)
 
   def _download_and_prepare_as_dataset(self, builder):
-    """ __TODO__ """
+    """ Download and prepare as dataset """
     # Provide the manual dir only if builder has MANUAL_DOWNLOAD_INSTRUCTIONS
     # set.
 
@@ -313,8 +313,7 @@ def _download_and_prepare_as_dataset(self, builder):
       with self._sub_test("as_dataset"):
         self._assert_as_dataset(builder_reloaded)
 
-  def _assert_as_dataset(self, builder):
-    """ __TODO__ """
+  def _assert_as_dataset(self, builder): # pylint: disable = missing-function-docstring
     split_to_checksums = {}  # {"split": set(examples_checksums)}
     for split_name, expected_examples_number in self.SPLITS.items():
       ds = builder.as_dataset(split=split_name)

tensorflow_datasets/testing/mocking_test.py

@@ -54,8 +54,7 @@ def test_mocking_lm1b(self):
         self.assertEqual(ex['text'].dtype, tf.int64)
         ex['text'].shape.assert_is_compatible_with((None,))
 
-  def test_custom_as_dataset(self):
-    """ __TODO__ """
+  def test_custom_as_dataset(self): # pylint: disable = missing-function-docstring
     def _as_dataset(self, *args, **kwargs):  # pylint: disable=unused-argument
       return tf.data.Dataset.from_generator(
           lambda: ({  # pylint: disable=g-long-lambda

tensorflow_datasets/testing/test_case.py

@@ -80,7 +80,7 @@ def assert_raises_with_predicate_match(self, err_type, predicate):
 
   @contextlib.contextmanager
   def assert_logs(self, text, level="info"):
-    """ __TODO__ """
+    """Log text messages with their level information"""
     with absltest.mock.patch.object(logging, level) as mock_log:
       yield
       concat_logs = ""

tensorflow_datasets/testing/test_utils.py

@@ -111,8 +111,7 @@ def setUpClass(cls):
     cls._sub_test_stack = []
 
   @contextlib.contextmanager
-  def _sub_test(self, test_str):
-    """ __TODO__ """
+  def _sub_test(self, test_str): # pylint: disable = missing-function-docstring
     sub_test_not_implemented = True
     if sub_test_not_implemented:
       yield

tensorflow_datasets/testing/test_utils_test.py

@@ -14,6 +14,7 @@
 # limitations under the License.
 
 # Lint as: python3
+# pylint: disable = C0114, C0115, C0116
 """Tests for tensorflow_datasets.core.test_utils."""
 
 from __future__ import absolute_import
@@ -29,9 +30,7 @@
 
 
 class RunInGraphAndEagerTest(test_case.TestCase):
-  """ __TODO__ """
   def test_run_in_graph_and_eager_modes(self):
-    """ __TODO__ """
     l = []
     def inc(self, with_brackets):
       del self  # self argument is required by run_in_graph_and_eager_modes.
@@ -53,12 +52,10 @@ def inc(self, with_brackets):
     })
 
   def test_run_in_graph_and_eager_modes_setup_in_same_mode(self):
-    """ __TODO__ """
     modes = []
     mode_name = lambda: "eager" if tf.executing_eagerly() else "graph"
 
     class ExampleTest(test_case.TestCase):
-      """ __TODO__ """
 
       def run_test(self):
         pass