Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Commit 67ca605

Browse files
afrozenatorcopybara-github
authored andcommitted
* Some more tests started enabling eager, so separate them out in pytest.
* Disable reversible_layers_test.py since that would either need to be tested against a new TFP release or against TFP nightly (this is a bigger change). * While debugging the above I found separating tests into top-level directories and having a catch-all for all other tests makes the errors on travis *much more readable* -- so doing that refactoring. PiperOrigin-RevId: 264667040
1 parent 0591d94 commit 67ca605

File tree

1 file changed

+58
-16
lines changed

1 file changed

+58
-16
lines changed

oss_scripts/oss_tests.sh

+58-16
Original file line numberDiff line numberDiff line change
@@ -28,60 +28,75 @@ fi
2828
python -c "from tensor2tensor.models import transformer; print(transformer.Transformer.__name__)"
2929
set_status
3030

31-
# Run tests
32-
# Ignores:
31+
# We need to run some tests separately (because they enable eager or due to
32+
# other reasons). We also test the tests in the top-level-directories separately
33+
# to get more readable error messages.
34+
3335
# Tested separately:
3436
# * registry_test
3537
# * trainer_lib_test
3638
# * visualization_test
3739
# * trainer_model_based_test
3840
# * allen_brain_test
3941
# * models/research
42+
43+
4044
# algorithmic_math_test: flaky
41-
# test_utils.py is not a test, but pytest thinks it is.
4245
# subword_text_encoder_ops_test, pack_sequences_ops_test: interface with C++ ops
43-
# trax tests need C++
44-
# TODO(davidso): Re-enable EvolvedTransformer when possible.
45-
# others (see below) enable eager, so can't be tested along with the others in
46-
# pytest
4746
pytest --disable-warnings \
48-
--ignore=tensor2tensor/bin/t2t_trainer_test.py \
4947
--ignore=tensor2tensor/data_generators/algorithmic_math_test.py \
5048
--ignore=tensor2tensor/data_generators/allen_brain_test.py \
5149
--ignore=tensor2tensor/data_generators/ops/pack_sequences_ops_test.py \
5250
--ignore=tensor2tensor/data_generators/ops/subword_text_encoder_ops_test.py \
5351
--ignore=tensor2tensor/data_generators/problem_test.py \
52+
tensor2tensor/data_generators
53+
set_status
54+
55+
56+
pytest --disable-warnings \
5457
--ignore=tensor2tensor/envs/mujoco_problems_test.py \
5558
--ignore=tensor2tensor/envs/rendered_env_problem_test.py \
59+
tensor2tensor/envs/
60+
set_status
61+
62+
63+
pytest --disable-warnings \
5664
--ignore=tensor2tensor/layers/bayes_test.py \
5765
--ignore=tensor2tensor/layers/common_attention_test.py \
5866
--ignore=tensor2tensor/layers/common_layers_test.py \
5967
--ignore=tensor2tensor/layers/common_video_test.py \
6068
--ignore=tensor2tensor/layers/discretization_test.py \
69+
--ignore=tensor2tensor/layers/gaussian_process_test.py \
6170
--ignore=tensor2tensor/layers/latent_layers_test.py \
6271
--ignore=tensor2tensor/layers/modalities_test.py \
6372
--ignore=tensor2tensor/layers/ngram_test.py \
6473
--ignore=tensor2tensor/layers/reversible_layers_test.py \
74+
tensor2tensor/layers/
75+
set_status
76+
77+
78+
# TODO(davidso): Re-enable EvolvedTransformer when possible.
79+
pytest --disable-warnings \
6580
--ignore=tensor2tensor/models/evolved_transformer_test.py \
6681
--ignore=tensor2tensor/models/research \
6782
--ignore=tensor2tensor/models/video/nfg_conv3d_test.py \
6883
--ignore=tensor2tensor/models/video/nfg_conv_lstm_test.py \
6984
--ignore=tensor2tensor/models/video/nfg_conv_test.py \
7085
--ignore=tensor2tensor/models/video/nfg_uncond_test.py \
71-
--ignore=tensor2tensor/rl \
72-
--ignore=tensor2tensor/trax \
86+
tensor2tensor/models/
87+
set_status
88+
89+
90+
# test_utils.py is not a test, but pytest thinks it is.
91+
pytest --disable-warnings \
7392
--ignore=tensor2tensor/utils/registry_test.py \
7493
--ignore=tensor2tensor/utils/t2t_model_test.py \
7594
--ignore=tensor2tensor/utils/test_utils.py \
7695
--ignore=tensor2tensor/utils/test_utils_test.py \
7796
--ignore=tensor2tensor/utils/trainer_lib_test.py \
78-
--ignore=tensor2tensor/visualization/visualization_test.py \
79-
--deselect=tensor2tensor/utils/beam_search_test.py::BeamSearchTest::testTPUBeam
97+
tensor2tensor/utils/
8098
set_status
8199

82-
# TODO(afrozm): Enable trax tests they currently need GLIBCXX_3.4.21
83-
# Travis Error:
84-
# ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/jaxlib/_pywrap_xla.so)
85100

86101
# These tests enable eager, so are tested separately.
87102
pytest --disable-warnings \
@@ -91,15 +106,21 @@ pytest --disable-warnings \
91106
tensor2tensor/layers/common_layers_test.py \
92107
tensor2tensor/layers/common_video_test.py \
93108
tensor2tensor/layers/discretization_test.py \
109+
tensor2tensor/layers/gaussian_process_test.py \
94110
tensor2tensor/layers/latent_layers_test.py \
95111
tensor2tensor/layers/modalities_test.py \
96112
tensor2tensor/layers/ngram_test.py \
97-
tensor2tensor/layers/reversible_layers_test.py \
113+
tensor2tensor/keras \
98114
tensor2tensor/utils/t2t_model_test.py \
99115
tensor2tensor/utils/test_utils_test.py \
100116
--deselect=tensor2tensor/layers/common_video_test.py::CommonVideoTest::testGifSummary
101117
set_status
102118

119+
# TODO(afrozm): Re-enable once TFP's new release comes out (0.8.0) or modify
120+
# stuff so that we test against tfp-nightly.
121+
#pytest --disable-warnings tensor2tensor/layers/reversible_layers_test.py
122+
#set_status
123+
103124
pytest --disable-warnings tensor2tensor/utils/registry_test.py
104125
set_status
105126

@@ -112,6 +133,27 @@ set_status
112133
pytest --disable-warnings tensor2tensor/data_generators/allen_brain_test.py
113134
set_status
114135

136+
# All other tests not tested above.
137+
138+
# trax tests need C++
139+
# TODO(afrozm): Enable trax tests they currently need GLIBCXX_3.4.21
140+
# Travis Error:
141+
# ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/jaxlib/_pywrap_xla.so)
142+
pytest --disable-warnings \
143+
--ignore=tensor2tensor/bin/t2t_trainer_test.py \
144+
--ignore=tensor2tensor/data_generators \
145+
--ignore=tensor2tensor/envs \
146+
--ignore=tensor2tensor/keras \
147+
--ignore=tensor2tensor/layers \
148+
--ignore=tensor2tensor/models \
149+
--ignore=tensor2tensor/rl \
150+
--ignore=tensor2tensor/trax \
151+
--ignore=tensor2tensor/utils \
152+
--ignore=tensor2tensor/visualization \
153+
--deselect=tensor2tensor/utils/beam_search_test.py::BeamSearchTest::testTPUBeam
154+
set_status
155+
156+
115157
# TODO(afrozm): Enable this unconditionally?
116158

117159
## Test models/research only against tf-nightly

0 commit comments

Comments
 (0)