Skip to content

Fix contours for face landmarks #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix contours for face landmarks #1519

wants to merge 1 commit into from

Conversation

@1j01
Copy link

@1j01 1j01 commented Dec 21, 2024

  • The contours had indices out of order, leading to ugly bridges across the mouth, eyes, and eyebrows.
  • The lips are actually two loops, inner and outer. I implemented support for multiple loops in connectionsToIndices, but didn't add special handling for that case in the demo's rendering, since the only artifact is a line in the corner of the mouth, and it's pretty subtle. I didn't want to make any API changes, but I would ideally separate this into lipsInner and lipsOuter.
  • The polygons are (still) not consistently clockwise or counter-clockwise.
  • The eyebrows were not closed polygons. I added the left/right edges that join the top and bottom polylines to close these shapes.

before/after comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@1j01