Remove unnecessarily mutable exports from tfjs-converter (#2509)

DEV

Mutable ESM exports can be difficult to reason about and are often not necessary.

Remove them in places that can use export const instead.

(At Google internally we forbid them and we are now cleaning up existing usages.)

Author: blickly

tfjs-converter/src/operations/executors/arithmetic_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/basic_math_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue, getTensor} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/convolution_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor =
+export const executeOp: InternalOpExecutor =
     (node: Node, tensorMap: NamedTensorsMap,
      context: ExecutionContext): tfc.Tensor[] => {
       switch (node.op) {

tfjs-converter/src/operations/executors/creation_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/evaluation_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor =
+export const executeOp: InternalOpExecutor =
     (node: Node, tensorMap: NamedTensorsMap,
      context: ExecutionContext): tfc.Tensor[] => {
       switch (node.op) {

tfjs-converter/src/operations/executors/graph_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue, getTensor} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/image_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/logical_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/matrices_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/normalization_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/reduction_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/slice_join_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {

tfjs-converter/src/operations/executors/spectral_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue} from './utils';
 
-export let executeOp: InternalOpExecutor =
+export const executeOp: InternalOpExecutor =
     (node: Node, tensorMap: NamedTensorsMap,
      context: ExecutionContext): tfc.Tensor[] => {
       switch (node.op) {

tfjs-converter/src/operations/executors/transformation_executor.ts

@@ -23,7 +23,7 @@ import {InternalOpExecutor, Node} from '../types';
 
 import {getParamValue, split} from './utils';
 
-export let executeOp: InternalOpExecutor = (node: Node,
+export const executeOp: InternalOpExecutor = (node: Node,
                                             tensorMap: NamedTensorsMap,
                                             context: ExecutionContext):
                                                tfc.Tensor[] => {