[possibly not a bug] app/build.gradle: oddly explicit sdkmanager path results in gradle build error

[robertkirkman]

Hello, I am not sure whether this project is intended to support local recompilation of the APK or not, if that is not intended and only the released APKs are supported, then this can be ignored.

When I used

./gradlew assembleDebug

This happened,

> Task :app:ensure-sources FAILED

> Task :app:gen-proto-keycodes
KeyCode enum up-to-date

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:ensure-sources'.
> A problem occurred starting process 'command '/mnt/Storage/Files/Application_Files/android-sdk/cmdline-tools/latest/bin/sdkmanager''

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 3s
32 actionable tasks: 32 executed
Configuration cache entry stored.

It seemed related to this block of code, because when I locally deleted this block and tried again, the error disappeared and the build was successful.

termux-gui/app/build.gradle

Lines 64 to 76 in b648a2d

	if (System.getenv("GITHUB_ACTIONS") == null) {
	tasks.register("gen-proto-keycodes") {
	actions.push(new UpdateProtoAction(projectDir.path, android.sdkDirectory.path, android.compileSdk.toString()))
	}
	tasks.register("ensure-sources", Exec.class) {
	it.commandLine(Paths.get(android.sdkDirectory.path, "cmdline-tools", "latest", "bin", "sdkmanager").toString(), "sources;android-" + android.compileSdk.toString())
	}
	tasks.preBuild {
	dependsOn("gen-proto-keycodes", "ensure-sources")
	}
	}

Do you know what this block is specifically for, and would it be OK to disable it by default for local builds?

[tareksander]

That block regenerates the protocol definitions from the Java source code of Android KeyEvents. You can delete that in your local copy, since the protobuf file itself is also versioned in git.

[tareksander]

On the other hand, a correctly installed Android sdk should work with that.

[robertkirkman]

you could be completely right, but for some reason my android sdk doesn't have an sdkmanager program, but it has always worked to build all other android apps and this is the only app that this happened with.

I am not sure why my android sdk doesn't have an sdkmanager program. I will try reproducing this using a clean installation of android sdk on a different computer in the way I normally install android sdk, to see if I can figure out what conditions need to happen for someone else trying to build Termux:GUI to not have an sdkmanager program.

[tareksander]

I disabled it for GitHub Actions, so the runners probably also don't have sdkmanager.

[Benjamin-Loison]

I confirm this issue on Debian 13.

Just commenting dependsOn("gen-proto-keycodes", "ensure-sources") is a workaround.

Personal notes: Benjamin_Loison/termux-gui/issues/2

[tareksander]

I'm on debian as well, but since the debian repos have a really outdated android sdk, I instead rely on the standard installation as defined by google, not a non-standard distribution layout.