fix: Updates from review

Author: bryantbiggs

examples/dsql/main.tf

@@ -4,7 +4,8 @@ provider "aws" {
 
 locals {
   name           = "ex-${basename(path.cwd)}"
-  region         = "us-east-1"
+  region1        = "us-east-1"
+  region2        = "us-east-2"
   witness_region = "us-west-2"
 
   tags = {
@@ -40,14 +41,14 @@ module "dsql_cluster_1" {
 module "dsql_cluster_2" {
   source = "../../modules/dsql"
 
-  region = local.witness_region
+  region = local.region2
 
   name = "${local.name}-2"
 
   # For example only
   deletion_protection_enabled = false
 
-  witness_region         = local.region
+  witness_region         = local.witness_region
   create_cluster_peering = true
   clusters               = [module.dsql_cluster_1.arn]
 

main.tf

@@ -584,9 +584,13 @@ resource "aws_rds_shard_group" "this" {
   publicly_accessible       = var.shard_group.publicly_accessible
   tags                      = merge(var.tags, var.shard_group.tags)
 
-  timeouts {
-    create = var.shard_group.timeouts.create
-    update = var.shard_group.timeouts.update
-    delete = var.shard_group.timeouts.delete
+  dynamic "timeouts" {
+    for_each = var.shard_group != null ? [var.shard_group] : []
+
+    content {
+      create = each.value.create
+      update = each.value.update
+      delete = each.value.delete
+    }
   }
 }

modules/dsql/main.tf

@@ -37,7 +37,11 @@ resource "aws_dsql_cluster_peering" "this" {
   identifier     = aws_dsql_cluster.this[0].identifier
   witness_region = var.witness_region
 
-  timeouts {
-    create = var.timeouts.create
+  dynamic "timeouts" {
+    for_each = var.timeouts != null ? [var.timeouts] : []
+
+    content {
+      create = each.value.create
+    }
   }
 }