Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: review use of client.Close #2776

Open
stevenh opened this issue Sep 10, 2024 · 0 comments
Open

[Enhancement]: review use of client.Close #2776

stevenh opened this issue Sep 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@stevenh
Copy link
Collaborator

stevenh commented Sep 10, 2024

Proposal

We should review the use of client.Close() which is pretty pervasive in the code and could be causing unnecessary connection churn.

I would expect 99% of all clients to use an underlying default client much like the stdlib http, which allows it to consistently reuse connections avoiding the overhead of establishing new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant