Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Enable CloudMap support in localstack module #5838

Closed
hariohmprasath opened this issue Sep 13, 2022 · 3 comments
Closed

[Enhancement]: Enable CloudMap support in localstack module #5838

hariohmprasath opened this issue Sep 13, 2022 · 3 comments

Comments

@hariohmprasath
Copy link
Contributor

hariohmprasath commented Sep 13, 2022

Module

LocalStack

Proposal

Enable CloudMap service support in localstack module. Based on @maciejwalkowiak conversation with localstack team AWS CloudMap is supported for pro-users, so if we can enable CloudMap service support in localstack module then customers can use this framework to run integration tests.

In fact I can use this support first now to create integration tests for my PR (awspring/spring-cloud-aws#506) open on adding CloudMap support to Spring Cloud.

@hariohmprasath
Copy link
Contributor Author

Since the change was simple enough, I have submitted a PR for this. Whenever you have some time review it and let you know your thoughts - #5839

@eddumelendez
Copy link
Member

Thanks for raising the issue! No need to create an issue if a PR is coming just right away, Testcontainers LocalStack Module already accepts new services using withServices(LocalStackContainer.EnabledService.named("servicediscovery")).

@eddumelendez eddumelendez closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
@hariohmprasath
Copy link
Contributor Author

Awesome and Thanks @eddumelendez, i wasn't aware of this. Appreciate your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants