Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linux package signing #396

Open
codefromthecrypt opened this issue Oct 10, 2021 · 1 comment
Open

Implement linux package signing #396

codefromthecrypt opened this issue Oct 10, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@codefromthecrypt
Copy link
Contributor

#395 removes linux package signing because it was broken and not noticed because it wasn't tested. Let's try again!

Notably, to know this works. the rpm and deb test scripts should verify signatures always, defaulting to the test ones.

Ex.
https://github.com/goreleaser/nfpm/blob/39f5bf392d22c9284f45cb9f5c34c06c4901fef1/testdata/acceptance/rpm.dockerfile#L68-L76
https://github.com/goreleaser/nfpm/blob/39f5bf392d22c9284f45cb9f5c34c06c4901fef1/testdata/acceptance/deb.dockerfile#L67-L78

@codefromthecrypt codefromthecrypt changed the title Implement package signing Implement linux package signing Oct 10, 2021
@codefromthecrypt
Copy link
Contributor Author

note: it seems github CLI signs external to nfpm. I don't necessarily care whether signing is done inside nfpm or external to it. However, we should probably do that internal to our makefile as opposed to shell scripts pasted into yaml https://github.com/cli/cli/blob/trunk/.github/workflows/releases.yml

@codefromthecrypt codefromthecrypt added the enhancement New feature or request label Oct 10, 2021
@codefromthecrypt codefromthecrypt added good first issue Good for newcomers and removed hacktoberfest labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant