Skip to content

Implement protocol detection and protocol-agnostic session creation.#187

Merged
tristanlabelle merged 6 commits into
thebrowsercompany:mainfrom
tristanlabelle:protocol-detection
May 2, 2025
Merged

Implement protocol detection and protocol-agnostic session creation.#187
tristanlabelle merged 6 commits into
thebrowsercompany:mainfrom
tristanlabelle:protocol-detection

Conversation

@tristanlabelle
Copy link
Copy Markdown
Contributor

The initial W3C protocol support required specifying the protocol depending on the webdriver server being used. This follows-up to abstract the protocol further when creating sessions and calling the status API.

Fixes #183, #184, #185

@tristanlabelle tristanlabelle requested review from a team, stevenbrix and z2oh April 30, 2025 02:11
Comment thread Sources/WebDriver/HTTPWebDriver.swift
Comment thread Sources/WebDriver/HTTPWebDriver.swift
Comment thread Sources/WebDriver/Requests.swift Outdated
Comment thread Sources/WebDriver/Session.swift
Comment thread Sources/WebDriver/Session.swift Outdated
Comment thread Sources/WebDriver/WebDriver.swift Outdated
Copy link
Copy Markdown

@z2oh z2oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans the missing .w3c initializer.

@tristanlabelle tristanlabelle merged commit eb79abd into thebrowsercompany:main May 2, 2025
3 checks passed
@tristanlabelle tristanlabelle deleted the protocol-detection branch May 2, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support creating sessions in a protocol-independent manner

3 participants