Skip to content

Commit d4940bd

Browse files
authored
Merge pull request #72 from moufmouf/oracle_aliases
Subquery aliases in Oracle don't accept the AS keyword
2 parents fda2a02 + 6afd03a commit d4940bd

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/SQLParser/Node/SubQuery.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public function toSql(array $parameters, AbstractPlatform $platform, int $indent
196196
}
197197
$sql .= '('.$this->subQuery->toSql($parameters, $platform, $indent, $conditionsMode, $extrapolateParameters).')';
198198
if ($this->alias) {
199-
$sql .= ' AS '.$platform->quoteSingleIdentifier($this->alias);
199+
$sql .= ' '.$platform->quoteSingleIdentifier($this->alias);
200200
}
201201
if ($this->refClause) {
202202
$sql .= ' ON ';

tests/Mouf/Database/MagicQueryTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,9 @@ public function testStandardSelect()
205205

206206
$sql = 'SELECT COUNT(*) FROM (SELECT DISTINCT states.country_id, states.code FROM states)';
207207
$this->assertEquals($sql, self::simplifySql($magicQuery->build($sql)));
208+
209+
$sql = 'SELECT COUNT(*) AS cnt FROM (SELECT id FROM country) subquery';
210+
$this->assertEquals($sql, self::simplifySql($magicQuery->build($sql)));
208211
}
209212

210213
/**

0 commit comments

Comments
 (0)