Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify sender when tests fail #21

Open
dLobatog opened this issue Feb 24, 2015 · 1 comment
Open

Notify sender when tests fail #21

dLobatog opened this issue Feb 24, 2015 · 1 comment

Comments

@dLobatog
Copy link
Member

Currently tests take a long time to run. Therefore most people who send a pull request don't wait until tests have finished running, and they don't know the status of their PR, instead they think everything is fine when the tests might have failed. I suggest the prprocessor should actually ping the person in question and tell the person how to run tests locally & a link to the failures in Jenkins.

Also the PR should be set as waiting on contributor as that's the state if fixes are required.

@domcleal
Copy link

It might be easiest to do this in test-pull-requests, which if you hunt through the old commits used to actually comment rather than using the GitHub status API (I converted it).

That said, keeping it in prprocessor might be more future proof as I'd quite like to replace test-p-r with the Jenkins PR testing plugin one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants