Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update survival analysis models #840

Closed
24 tasks done
aGuyLearning opened this issue Dec 13, 2024 · 1 comment · Fixed by #842
Closed
24 tasks done

Update survival analysis models #840

aGuyLearning opened this issue Dec 13, 2024 · 1 comment · Fixed by #842
Assignees
Labels
enhancement New feature or request

Comments

@aGuyLearning
Copy link
Collaborator

aGuyLearning commented Dec 13, 2024

Description of feature

Pass along arguments of the models in _sa.py and write output to Andata object.

Regression Models

cox_ph

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")

weibull_aft

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")

log_logistic_aft

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")

Univariate Models

nelson_aalen

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")

weibull

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")

kaplan_meier

  • add arguments of liefelines function
  • write output to anndata object
  • key_added keyword (work in progress) for new entries
  • make everything after adata, duration_col keyword only ("*,")
@aGuyLearning aGuyLearning added the enhancement New feature or request label Dec 13, 2024
@aGuyLearning aGuyLearning self-assigned this Dec 13, 2024
@aGuyLearning aGuyLearning linked a pull request Dec 20, 2024 that will close this issue
@eroell
Copy link
Collaborator

eroell commented Jan 8, 2025

Suggest to have everything after everything after adata, duration_col, event_col as keyword only, as we have this pattern now already for kaplan_meier and its still simple enough

@aGuyLearning aGuyLearning changed the title Update survival analysis regression models Update survival analysis models Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants