Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: TaskList generates a disabled checkbox #589

Closed
fkoji opened this issue Nov 24, 2020 · 2 comments
Closed

Question: TaskList generates a disabled checkbox #589

fkoji opened this issue Nov 24, 2020 · 2 comments
Labels
question General questions about the project or usage

Comments

@fkoji
Copy link

fkoji commented Nov 24, 2020

Question

The <input type="checkbox"> elements converted - [ ] using TaskList extension have a disabled attribute. Is this an expected behavior?

スクリーンショット 2020-11-24 16 32 14

@fkoji fkoji added the question General questions about the project or usage label Nov 24, 2020
@colinodell
Copy link
Member

Yes, this behavior is expected and intentional: https://github.com/thephpleague/commonmark/blob/1.5.7/src/Extension/TaskList/TaskListItemMarkerRenderer.php#L39

This aligns with other Markdown parsers (like Markdig) which have the ability to render checkboxes but don't offer functionality to update the Markdown contents when the checkboxes are clicked. Once #511 is implemented I'd feel comfortable making these non-disabled by default.

@fkoji
Copy link
Author

fkoji commented Nov 24, 2020

Thank you for your reply. For now, I'm going to use JavaScript to update the attributes.

@fkoji fkoji closed this as completed Nov 24, 2020
@thephpleague thephpleague locked and limited conversation to collaborators Jun 12, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question General questions about the project or usage
Projects
None yet
Development

No branches or pull requests

2 participants