Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package still maintained? #251

Closed
AlessandroAmos opened this issue Apr 12, 2023 · 5 comments
Closed

Is this package still maintained? #251

AlessandroAmos opened this issue Apr 12, 2023 · 5 comments

Comments

@AlessandroAmos
Copy link

No description provided.

@gpn273
Copy link

gpn273 commented Jun 14, 2023

Equally wondering this myself. I have been attempting to upgrade a project from 3.x to 4.x, all going well until I spotted an issue whilst the container was trying to resolve a class which has nullable ?\DateTime $date = null in the constructor. This works fine on 3.x, but not on 4.x.

I am using PHP 8.1.

TypeError: DateTimeZone::__construct(): Argument #1 ($timezone) must be of type string, League\Container\Argument\ResolvableArgument given

    /var/www/vendor/league/container/src/ReflectionContainer.php:58

    DateTimeZone->__construct
    /var/www/vendor/league/container/src/ReflectionContainer.php:58
    /var/www/vendor/league/container/src/Container.php:189
    /var/www/vendor/league/container/src/Container.php:111
    /var/www/vendor/league/container/src/Argument/ArgumentResolverTrait.php:45
    /var/www/vendor/league/container/src/Argument/ArgumentResolverTrait.php:107
    /var/www/vendor/league/container/src/ReflectionContainer.php:58
    /var/www/vendor/league/container/src/Container.php:189
    /var/www/vendor/league/container/src/Container.php:111
    /var/www/vendor/league/container/src/Argument/ArgumentResolverTrait.php:45
    /var/www/vendor/league/container/src/Argument/ArgumentResolverTrait.php:107
    /var/www/vendor/league/container/src/ReflectionContainer.php:58
    /var/www/vendor/league/container/src/Container.php:189
    /var/www/vendor/league/container/src/Container.php:111

Although I don't want to jump ship to an alternative package if issues are being resolved, decisions may have to be made soon. Understand this is an open-source project, and the maintainer may not have time to resolve these issues anymore.

@bertramakers
Copy link

Wondering this as well. Ran into the bug reported in #240, which has a fix PR waiting to be reviewed/merged for more than half a year now (#248). Last commit on the default branch was over a 1,5 years ago.

Also, league/route is maintained by the same person and seems equally inactive based on the commits in the main branch and open issues without replies: https://github.com/thephpleague/route

@philipobenito
Copy link
Member

philipobenito commented Jun 29, 2023 via email

@bertramakers
Copy link

That's great to hear! Sorry you've had to deal with health issues. Love the packages so I'm happy to hear that they will still be maintained. All the best!

@philipobenito
Copy link
Member

See #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants