1.29: linking fails on macOS: `Undefined symbols for architecture x86_64: "___emutls_get_address"`, `Undefined symbols for architecture x86_64: "_ffi_call"`

[barracuda156]

@thepowersgang @catap Somehow these two issues are still there with 1.29:

--- BUILDING rustc_driver v0.0.0 (98.1% 1r,0w,1b,103c/105t)
> /opt/local/libexec/mrustc/bin/mrustc /opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/rustc-1.29.2-src/src/librustc_driver/lib.rs -o output/rustc-build/librustc_driver.rlib -C emit-depfile=output/rustc-build/librustc_driver.rlib.d --cfg debug_assertions -O -L output -L output/rustc-build --crate-name rustc_driver --crate-type rlib --crate-tag 0_0_0 --extern arena=output/rustc-build/libarena.rlib --extern graphviz=output/rustc-build/libgraphviz.rlib --extern log=output/rustc-build/liblog-0_4_3_H8200.rlib --extern env_logger=output/rustc-build/libenv_logger-0_5_10.rlib --extern rustc_rayon=output/rustc-build/librustc_rayon-0_1_1.rlib --extern scoped_tls=output/rustc-build/libscoped_tls-0_1_2_H1.rlib --extern rustc=output/rustc-build/librustc.rlib --extern rustc_allocator=output/rustc-build/librustc_allocator.rlib --extern rustc_target=output/rustc-build/librustc_target.rlib --extern rustc_borrowck=output/rustc-build/librustc_borrowck.rlib --extern rustc_data_structures=output/rustc-build/librustc_data_structures.rlib --extern rustc_errors=output/rustc-build/librustc_errors.rlib --extern rustc_incremental=output/rustc-build/librustc_incremental.rlib --extern rustc_lint=output/rustc-build/librustc_lint.rlib --extern rustc_metadata=output/rustc-build/librustc_metadata.rlib --extern rustc_mir=output/rustc-build/librustc_mir.rlib --extern rustc_passes=output/rustc-build/librustc_passes.rlib --extern rustc_plugin=output/rustc-build/librustc_plugin.rlib --extern rustc_privacy=output/rustc-build/librustc_privacy.rlib --extern rustc_resolve=output/rustc-build/librustc_resolve.rlib --extern rustc_save_analysis=output/rustc-build/librustc_save_analysis.rlib --extern rustc_traits=output/rustc-build/librustc_traits.rlib --extern rustc_codegen_utils=output/rustc-build/librustc_codegen_utils.rlib --extern rustc_typeck=output/rustc-build/librustc_typeck.rlib --extern serialize=output/rustc-build/libserialize.rlib --extern syntax=output/rustc-build/libsyntax.rlib --extern syntax_ext=output/rustc-build/libsyntax_ext.rlib --extern syntax_pos=output/rustc-build/libsyntax_pos.rlib --extern rustc_codegen_llvm=output/rustc-build/librustc_codegen_llvm.rlib > output/rustc-build/librustc_driver.rlib_dbg.txt
 (98.1% 1r,0w,1b,103c/105t): rustc_driver v0.0.0
warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option]
1 warning generated.
Completed rustc_driver v0.0.0
 (99.0% 0r,0w,1b,104c/105t):
--- BUILDING rustc-main v0.0.0 [bin rustc_binary] (99.0% 1r,0w,0b,104c/105t)
> /opt/local/libexec/mrustc/bin/mrustc /opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/rustc-1.29.2-src/src/rustc/rustc.rs -o output/rustc-build/rustc_binary -C emit-depfile=output/rustc-build/rustc_binary.d --cfg debug_assertions -O -L output -L output/rustc-build --cfg feature="curl-sys/force-system-lib-on-osx" --crate-name rustc_binary --crate-type bin --crate-tag 0_0_0_H0 --extern rustc_target=output/rustc-build/librustc_target.rlib --extern rustc_driver=output/rustc-build/librustc_driver.rlib > output/rustc-build/rustc_binary_dbg.txt
 (99.0% 1r,0w,0b,104c/105t): rustc-main v0.0.0 [bin rustc_binary]
<null> warn:0:Multiple panic_runtime crates loaded - panic_abort-0_0_0 and panic_unwind-0_0_0_H0
warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option]
1 warning generated.
Undefined symbols for architecture x86_64:
  "_ffi_call", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, llvm::ArrayRef<llvm::GenericValue>) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_prep_cif", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, llvm::ArrayRef<llvm::GenericValue>) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_double", referenced from:
      ffiTypeFor(llvm::Type*) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_float", referenced from:
      ffiTypeFor(llvm::Type*) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
      l_switch.table._ZL10ffiTypeForPN4llvm4TypeE in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_pointer", referenced from:
      ffiTypeFor(llvm::Type*) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint16", referenced from:
      l_switch.table._ZL10ffiTypeForPN4llvm4TypeE in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint32", referenced from:
      l_switch.table._ZL10ffiTypeForPN4llvm4TypeE in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint64", referenced from:
      l_switch.table._ZL10ffiTypeForPN4llvm4TypeE in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint8", referenced from:
      l_switch.table._ZL10ffiTypeForPN4llvm4TypeE in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_void", referenced from:
      ffiTypeFor(llvm::Type*) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
C Compiler failed to execute - error code 256
Process exited with non-zero exit status 1
FAILING COMMAND: /opt/local/libexec/mrustc/bin/mrustc /opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/rustc-1.29.2-src/src/rustc/rustc.rs -o output/rustc-build/rustc_binary -C emit-depfile=output/rustc-build/rustc_binary.d --cfg debug_assertions -O -L output -L output/rustc-build --cfg feature="curl-sys/force-system-lib-on-osx" --crate-name rustc_binary --crate-type bin --crate-tag 0_0_0_H0 --extern rustc_target=output/rustc-build/librustc_target.rlib --extern rustc_driver=output/rustc-build/librustc_driver.rlib
Env:  OUT_DIR=/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/output/rustc-build/build_rustc-main CARGO_MANIFEST_DIR=/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/rustc-1.29.2-src/src/rustc CARGO_PKG_NAME=rustc-main CARGO_PKG_VERSION=0.0.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=0
 (100.0% 0r,0w,0b,105c/105t):
BUILD FAILED
make[1]: *** [output/rustc] Error 1

Upstream issue: rust-lang/rust#34486
After I added patch for it, this one failed then:

Completed test v0.0.0
 (100.0% 0r,0w,0b,3c/3t):
error: linking with `/usr/bin/clang++` failed: exit code: 1
  |
  = note: "/usr/bin/clang++" "-m64" "-L" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib" "output/prefix-s/bin/hello_world.hello0.rcgu.o" "output/prefix-s/bin/hello_world.hello1.rcgu.o" "output/prefix-s/bin/hello_world.hello2.rcgu.o" "output/prefix-s/bin/hello_world.hello3.rcgu.o" "output/prefix-s/bin/hello_world.hello4.rcgu.o" "output/prefix-s/bin/hello_world.hello5.rcgu.o" "-o" "output/prefix-s/bin/hello_world" "output/prefix-s/bin/hello_world.crate.allocator.rcgu.o" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/" "-L" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/libstd.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/libpanic_unwind.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/libunwind.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/liballoc_system.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/liblibc.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/liballoc.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/libcore.rlib" "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc/output/prefix-s/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins.rlib" "-lSystem" "-lresolv" "-lc" "-lm"
  = note: Undefined symbols for architecture x86_64:
            "___emutls_get_address", referenced from:
                std::io::stdio::LOCAL_STDOUT::__getit::hdc93fe140d281407 in libstd.rlib(libstd.std2-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
                std::sys_common::thread_info::THREAD_INFO::__getit::hdf0e1bef5118cf32 in libstd.rlib(libstd.std13-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
                std::panicking::try::hd462a9892af3277c in libstd.rlib(libstd.std8-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
                std::panicking::rust_panic_with_hook::hac4bf8aea8f374b1 in libstd.rlib(libstd.std8-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
                std::panicking::LOCAL_STDERR::__getit::h45cd5c7577515cd7 in libstd.rlib(libstd.std8-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
                std::panicking::update_panic_count::PANIC_COUNT::__getit::h899636154e27f44b in libstd.rlib(libstd.std8-52e547d6d6be8d12a357a339b8cf3cae.rs.rcgu.o)
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)
          

make: *** [output/prefix-s/bin/hello_world] Abort trap: 6
make: Leaving directory `/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea/run_rustc'
Command failed:  cd "/opt/local/var/macports/build/mrustc-rust-451cc08d/work/mrustc-da4075f17328474ba90d2b3b56dde6be1954eeea" && /usr/bin/make -j8 -w /usr/bin/make -j1 -C run_rustc all 
Exit code: 2

rust-lang/rust#59164

This on 10.15 x86_64 with the current master, rustc 1.29.2, Xcode clang and llvm 7.0 (I just wanna get this building on x86 first, and then deal with powerpc).

[barracuda156]

MacPorts added a dependency on compiler-rt for this: macports/macports-ports@2625118 (though only for old systems back then).

[barracuda156]

May or may not be relevant, but on x86_64 I have used a standard LLVM 7 port, however @iains version has added the following:
iains/LLVM-7-branch@10d60b1

Though later they were removed: iains/LLVM-7-branch@01e3f4f

Could be that Catalina’s clang still needs these.

[iains]

May or may not be relevant, but on x86_64 I have used a standard LLVM 7 port, however @iains version has added the following: iains/LLVM-7-branch@10d60b1

Though later they were removed: iains/LLVM-7-branch@01e3f4f

Could be that Catalina’s clang still needs these.

Those exports are needed when building with GCC's emulated TLS (and the GCC is early); Current versions of GCC have specs to automate this. They should not be needed if you are building with clang (OTOH they should also be harmless)

[barracuda156]

@iains Thank you for clarifying. It could be a bug in 1.29, at least I did not face it when building 1.54. (Generally looks like old versions are pretty broken even on x86_64, at least when bootstrapping.)

Do you know what may be causing CodeModel error like here? #300 (comment)

It seems to originate from PassWrapper in rustc code, but I cannot figure out why this specifically fails on powerpc but not x86_64, when both use LLVM-7.

[iains]

@iains Thank you for clarifying. It could be a bug in 1.29, at least I did not face it when building 1.54. (Generally looks like old versions are pretty broken even on x86_64, at least when bootstrapping.)

Do you know what may be causing CodeModel error like here? #300 (comment)

Nope...

It seems to originate from PassWrapper in rustc code, but I cannot figure out why this specifically fails on powerpc but not x86_64, when both use LLVM-7.

... but it would not surprise me if it just was not expecting to see powerpc-darwin as a possible target.

[barracuda156]

but it would not surprise me if it just was not expecting to see powerpc-darwin as a possible target.

I have added target specs, if you mean rustc code. Of course, something may be / likely is not ABI-compliant, but that should not error out the way it is.