test: PC10 residency and resume time

ekurdybx · ekurdybx · commit 7876d0b546ab · 2025-11-12T18:00:09.000+01:00
Signed-off-by: Emilia Kurdybelska &lt;emiliax.kurdybelska@intel.com&gt;
diff --git a/test-case/check-suspend-resume.sh b/test-case/check-suspend-resume.sh
@@ -26,27 +26,33 @@ source "$TOPDIR"/case-lib/lib.sh
 random_min=3    # wait time should >= 3 for other device wakeup from sleep
 random_max=20
 
-OPT_NAME['l']='loop'     OPT_DESC['l']='loop count'
-OPT_HAS_ARG['l']=1       OPT_VAL['l']=5
+OPT_NAME['l']='loop'                   OPT_DESC['l']='loop count'
+OPT_HAS_ARG['l']=1                     OPT_VAL['l']=5
 
-OPT_NAME['T']='type'     OPT_DESC['T']="suspend/resume type from /sys/power/mem_sleep"
-OPT_HAS_ARG['T']=1       OPT_VAL['T']=""
+OPT_NAME['T']='type'                   OPT_DESC['T']="suspend/resume type from /sys/power/mem_sleep"
+OPT_HAS_ARG['T']=1                     OPT_VAL['T']=""
 
-OPT_NAME['S']='sleep'    OPT_DESC['S']='suspend/resume command:rtcwake sleep duration'
-OPT_HAS_ARG['S']=1       OPT_VAL['S']=5
+OPT_NAME['S']='sleep'                  OPT_DESC['S']='suspend/resume command:rtcwake sleep duration'
+OPT_HAS_ARG['S']=1                     OPT_VAL['S']=5
 
-OPT_NAME['u']='unload-audio'  OPT_DESC['u']='unload audio modules for the test'
-OPT_HAS_ARG['u']=0            OPT_VAL['u']=0
+OPT_NAME['u']='unload-audio'           OPT_DESC['u']='unload audio modules for the test'
+OPT_HAS_ARG['u']=0                     OPT_VAL['u']=0
 
-OPT_NAME['w']='wait'     OPT_DESC['w']='idle time after suspend/resume wakeup'
-OPT_HAS_ARG['w']=1       OPT_VAL['w']=5
+OPT_NAME['w']='wait'                   OPT_DESC['w']='idle time after suspend/resume wakeup'
+OPT_HAS_ARG['w']=1                     OPT_VAL['w']=5
 
-OPT_NAME['r']='random'   OPT_DESC['r']="Randomly setup wait/sleep time, range is [$random_min-$random_max], this option will overwrite s & w option"
-OPT_HAS_ARG['r']=0       OPT_VAL['r']=0
+OPT_NAME['r']='random'                 OPT_DESC['r']="Randomly setup wait/sleep time, range is [$random_min-$random_max], this option will overwrite s & w option"
+OPT_HAS_ARG['r']=0                     OPT_VAL['r']=0
 
 # processid is set by check-suspend-resume-with-audio.sh for audio test case
-OPT_NAME['p']='processid'     OPT_DESC['p']='Fail immediately if this process dies'
-OPT_HAS_ARG['p']=1            OPT_VAL['p']=''
+OPT_NAME['p']='processid'              OPT_DESC['p']='Fail immediately if this process dies'
+OPT_HAS_ARG['p']=1                     OPT_VAL['p']=''
+
+OPT_NAME['s']='run-sleepgraph'         OPT_DESC['s']='run with sleepgraph'
+OPT_HAS_ARG['s']=0                     OPT_VAL['s']=0
+
+OPT_NAME['t']='times-thresholds'       OPT_DESC['t']='sleepgraph thresholds'
+OPT_HAS_ARG['t']=1                     OPT_VAL['t']=''
 
 func_opt_parse_option "$@"
 func_lib_check_sudo
@@ -69,21 +75,29 @@ dlogi "Current suspend/resume type mode: $(cat /sys/power/mem_sleep)"
 loop_count=${OPT_VAL['l']}
 declare -a sleep_lst wait_lst
 
-if [ ${OPT_VAL['r']} -eq 1 ]; then
+if [ "${OPT_VAL['r']}" -eq 1 ]; then
     # create random number list
-    for i in $(seq 1 $loop_count)
+    for i in $(seq 1 "$loop_count")
     do
-        sleep_lst[$i]=$(func_lib_get_random $random_max $random_min)
-        wait_lst[$i]=$(func_lib_get_random $random_max $random_min)
+        sleep_lst[i]=$(func_lib_get_random $random_max $random_min)
+        wait_lst[i]=$(func_lib_get_random $random_max $random_min)
     done
 else
-    for i in $(seq 1 $loop_count)
+    for i in $(seq 1 "$loop_count")
     do
-        sleep_lst[$i]=${OPT_VAL['S']}
-        wait_lst[$i]=${OPT_VAL['w']}
+        sleep_lst[i]=${OPT_VAL['S']}
+        wait_lst[i]=${OPT_VAL['w']}
     done
 fi
 
+if [ "${OPT_VAL['s']}" -eq 1 ]; then
+    SLEEPGRAPH_PATH="$HOME/pm-graph/sleepgraph.py"
+    if [ ! -f "$SLEEPGRAPH_PATH" ]; then
+        echo "Sleepgraph is not installed! Exiting..."
+        exit 1
+    fi
+fi
+
 save_initial_stats()
 {
     printf '\n\n'
@@ -143,7 +157,7 @@ main()
 
     local keep_modules=true already_unloaded=false
 
-    if [ ${OPT_VAL['u']} = 1 ]; then
+    if [ "${OPT_VAL['u']}" = 1 ]; then
         keep_modules=false
     fi
 
@@ -159,7 +173,7 @@ main()
     expected_wakeup_count=$(cat /sys/power/wakeup_count)
     expected_stats_success=$(cat /sys/power/suspend_stats/success)
     save_initial_stats
-    for i in $(seq 1 $loop_count)
+    for i in $(seq 1 "$loop_count")
     do
         sleep_once "$i"
     done
@@ -170,6 +184,40 @@ main()
         die "Found kernel error after reloading audio drivers"
 }
 
+analyze_sleepgraph_results()
+{
+    dlogi "Analyzing sleepgraph results"
+    results_file=$(find suspend-*/*.html)
+    cp "$results_file" "$LOG_ROOT/"
+    thresholds="${OPT_VAL['t']}"
+
+    dlogi "Analyzing $results_file file..."
+    if python3 "$SCRIPT_HOME"/tools/analyze-sleepgraph-results.py "$results_file" "$thresholds"; then
+        dlogi "All times measurements within the thresholds"
+        return 0
+    else
+        dlogw "Time measurements not within the thresholds!"
+        return 1
+    fi
+}
+
+run_rtcwake()
+{
+    if [ "${OPT_VAL['s']}" -eq 1 ]; then
+        # remove any files from previous sleepgraph runs
+        rm -rf suspend-*
+
+        dlogc "Run the command: $SLEEPGRAPH_PATH -rtcwake ${sleep_lst[$i]} -m freeze"
+        sudo "$SLEEPGRAPH_PATH" -rtcwake "${sleep_lst[$i]}" -m freeze ||
+            dump_and_die "rtcwake returned $?"
+        analyze_sleepgraph_results
+    else
+        dlogc "Run the command: rtcwake -m mem -s ${sleep_lst[$i]}"
+        sudo rtcwake -m mem -s "${sleep_lst[$i]}" ||
+            dump_and_die "rtcwake returned $?"
+    fi
+}
+
 sleep_once()
 {
     local i="$1"
@@ -179,9 +227,7 @@ sleep_once()
     setup_kernel_check_point
     expected_wakeup_count=$((expected_wakeup_count+1))
     expected_stats_success=$((expected_stats_success+1))
-    dlogc "Run the command: rtcwake -m mem -s ${sleep_lst[$i]}"
-    sudo rtcwake -m mem -s "${sleep_lst[$i]}" ||
-        dump_and_die "rtcwake returned $?"
+    run_rtcwake
     dlogc "sleep for ${wait_lst[$i]}"
     sleep ${wait_lst[$i]}
     dlogi "Check for the kernel log status"
diff --git a/test-case/sleepgraph-wrapper.sh b/test-case/sleepgraph-wrapper.sh
@@ -0,0 +1,34 @@
+#!/bin/bash
+
+##
+## Case Name: Wrapper to run a given test case with sleepgraph.py in setup that cannot set the environment variable. 
+##    Keep this script as simple as possible and avoid additional layers of indirections when possible.
+## Preconditions: 
+##    Sleepgraph.py script is available.
+## Description:
+##    This script serves as a wrapper to execute a test case script with additionally running sleepgraph.py.
+##    It expects the test case script file name (without path) as the first parameter,
+##    followed by other parameters required for that test case.
+##
+
+set -e
+
+# Ensure the test case script file name is provided
+if [ -z "$1" ]; then
+    echo "Error: No test case script file name provided. Exiting..."
+    exit 1
+fi
+
+# Check if sleepgraph is installed
+export SLEEPGRAPH_PATH="$HOME/pm-graph/sleepgraph.py"
+if [ ! -f "$SLEEPGRAPH_PATH" ]; then
+    echo "Sleepgraph is not installed! Exiting..."
+    exit 1
+fi
+
+export RUN_SLEEPGRAPH=true
+
+TESTDIR=$(realpath -e "$(dirname "${BASH_SOURCE[0]}")/..")
+
+# shellcheck disable=SC2145
+[ -x "$TESTDIR/test-case/$(basename "$1")" ] && exec "$TESTDIR"/test-case/"$@"
diff --git a/test-case/test-socwatch.sh b/test-case/test-socwatch.sh
@@ -38,7 +38,7 @@ OPT_NAME['u']='unload-audio'  OPT_DESC['u']='unload audio modules for the test'
 OPT_HAS_ARG['u']=0            OPT_VAL['u']=0
 
 : "${SOCWATCH_PATH:=$HOME/socwatch}"
-SOCWATCH_VERSION=$("$SOCWATCH_PATH"/socwatch --version |grep Version)
+SOCWATCH_VERSION=$(sudo "$SOCWATCH_PATH"/socwatch --version |grep Version)
 
 # reference cmd: sudo ./socwatch -t 20 -s 5 -f cpu-cstate -f pkg-pwr -o fredtest5
 #SOCWATCH_CMD="./socwatch"
@@ -57,41 +57,57 @@ check_socwatch_module_loaded()
     lsmod | grep -q socwatch || dlogi "socwatch is not loaded"
 }
 
+check_for_PC10_state()
+{
+    pc10_count=$(awk '/Package C-State Summary: Entry Counts/{f=1; next} f && /PC10/{print $3; exit}' $socwatch_output.csv)
+    if [ -z "$pc10_count" ]; then
+        die "PC10 State not achieved"
+    fi
+    dlogi "Entered into PC10 State $pc10_count times"
+
+    pc10_per=$(awk '/Package C-State Summary: Residency/{f=1; next} f && /PC10/{print $3; exit}' $socwatch_output.csv)
+    pc10_time=$(awk '/Package C-State Summary: Residency/{f=1; next} f && /PC10/{print $5; exit}' $socwatch_output.csv)
+    dlogi "Spent $pc10_time ms ($pc10_per %) in PC10 State"
+
+    json_str=$( jq -n \
+                --arg id "$i" \
+                --arg cnt "$pc10_count" \
+                --arg time "$pc10_time" \
+                --arg per "$pc10_per" \
+                '{$id: {pc10_entires_count: $cnt, time_ms: $time, time_percentage: $per}}' )
+
+    results=$(jq --slurp 'add' <(echo "$results") <(echo "$json_str"))
+}
+
 socwatch_test_once()
 {
     local i="$1"
     dlogi "===== Loop($i/$loop_count) ====="
     dlogi "SoCWatch version: ${SOCWATCH_VERSION}"
 
+    socwatch_output="$LOG_ROOT/socwatch-results/socwatch_output_$i"
+
     # set up checkpoint for each iteration
     setup_kernel_check_point
 
-    # load socwatch module, if the module is loaded, go ahead with the testing (-q)
-    sudo "$SOCWATCH_PATH"/drivers/insmod-socwatch -q || true
-    check_socwatch_module_loaded || die "socwatch module not loaded"
-
     ( set -x
-      sudo "$SOCWATCH_PATH"/socwatch -t "$duration" -s "$wait_time" "${SOCWATCH_FEATURE_PARAMS[@]}" -o "$SOCWATCH_PATH/sofsocwatch-$i" ) ||
+      sudo "$SOCWATCH_PATH"/socwatch -m -f sys -f cpu -f cpu-hw -f pcie -f hw-cpu-cstate \
+      -f pcd-slps0 -f tcss-state -f tcss -f pcie-lpm -n 200 -t "$duration" -s "$wait_time" \
+      -r json -o "$socwatch_output" ) ||
     die "socwatch returned $?"
 
-    # filter output and copy to log directory
-    grep "Package C-State Summary: Residency" -B 8 -A 11 "$SOCWATCH_PATH/sofsocwatch-$i.csv" | tee "$SOCWATCH_PATH/socwatch-$i.txt"
-    grep "Package Power Summary: Average Rate" -B 6 -A 4 "$SOCWATCH_PATH/sofsocwatch-$i.csv" | tee -a "$SOCWATCH_PATH/socwatch-$i.txt"
-    # zip original csv report
-    gzip "$SOCWATCH_PATH/sofsocwatch-$i.csv"
-    mv "$SOCWATCH_PATH/socwatch-$i.txt" "$SOCWATCH_PATH/sofsocwatch-$i.csv.gz" "$LOG_ROOT"/
+    # analyze SoCWatch results
+    check_for_PC10_state
 
-    dlogi "Check for the kernel log status"
     # check kernel log for each iteration to catch issues
+    dlogi "Check for the kernel log status"
     sof-kernel-log-check.sh "$KERNEL_CHECKPOINT" || die "Caught error in kernel log"
-
-    # unload socwatch module
-    sudo "$SOCWATCH_PATH"/drivers/rmmod-socwatch || true
 }
 
-main()
+unload_modules()
 {
-    local keep_modules=true already_unloaded=false
+    keep_modules=true
+    already_unloaded=false
 
     [ -d "$SOCWATCH_PATH" ] ||
         die "SOCWATCH not found in SOCWATCH_PATH=$SOCWATCH_PATH"
@@ -108,20 +124,44 @@ main()
 
     $already_unloaded || $keep_modules || "$TOPDIR"/tools/kmod/sof_remove.sh ||
         die "Failed to unload audio drivers"
+}
+
+load_modules()
+{
+    $already_unloaded || $keep_modules || "$TOPDIR"/tools/kmod/sof_insert.sh ||
+        die "Failed to reload audio drivers"
+    sof-kernel-log-check.sh "$KERNEL_CHECKPOINT" ||
+        die "Found kernel error after reloading audio drivers"
+}
+
+run_socwatch_tests()
+{
+    # load socwatch module, if the module is loaded, go ahead with the testing
+    sudo "$SOCWATCH_PATH"/drivers/insmod-socwatch || true
+    check_socwatch_module_loaded || die "socwatch module not loaded"
+
+    mkdir "$LOG_ROOT/socwatch-results"
+    pc10_results_file="$LOG_ROOT/socwatch-results/pc10_results.json"
+    touch "$pc10_results_file"
 
-    # socwatch test from here
     for i in $(seq 1 "$loop_count")
     do
         socwatch_test_once "$i"
     done
+    echo "$results" > "$pc10_results_file"
 
-    $already_unloaded || $keep_modules || "$TOPDIR"/tools/kmod/sof_insert.sh ||
-        die "Failed to reload audio drivers"
-    sof-kernel-log-check.sh "$KERNEL_CHECKPOINT" ||
-        die "Found kernel error after reloading audio drivers"
+    # zip all SoCWatch reports
+    tar -zcvf "$LOG_ROOT/socwatch-results.tar.gz" "$LOG_ROOT/socwatch-results/"
 
-    # DON"T delete socwatch directory after test, delete before new test
-    # rm -rf $SOCWATCH_PATH
+    # unload socwatch module
+    sudo "$SOCWATCH_PATH"/drivers/rmmod-socwatch
+}
+
+main()
+{
+    unload_modules
+    run_socwatch_tests
+    load_modules
 }
 
 main "$@"
diff --git a/tools/analyze-sleepgraph-results.py b/tools/analyze-sleepgraph-results.py
@@ -0,0 +1,71 @@
+from bs4 import BeautifulSoup
+from pathlib import Path
+import re
+import sys
+import json
+import os
+
+ACCEPTANCE_RANGE=0.2
+
+
+def analyze_sleepgraph_file(file, thresholds, acceptance_range=ACCEPTANCE_RANGE):
+    with open(file, 'r', encoding='utf-8') as f:
+        soup = BeautifulSoup(f, 'lxml')
+        complete_results={}
+        test_passed=True
+
+        components=thresholds.keys()
+        for component in components:
+            results = {}
+            divs = soup.find_all("div", title=lambda t: t and component in t)
+
+            for div in divs:
+                title = div.get('title')
+                match = re.search(r'\((\d+(?:\.\d+)?)\s*ms\)\s+(\S+)$', title)
+                if match:
+                    time_ms = float(match.group(1))
+                    measurement_name = match.group(2)
+                    if measurement_name in thresholds[component]:
+                        results[measurement_name] = {"value": time_ms, "pass": True}
+                        threshold = float(thresholds[component][measurement_name])
+                        if time_ms<(threshold * (1-acceptance_range)) and time_ms>(threshold * (1+acceptance_range)):
+                            results[measurement_name]["pass"] = False
+                            test_passed = False
+
+        complete_results[component]=results
+
+        print(complete_results)
+        return test_passed, complete_results
+
+
+def save_results_to_file(results):
+    results_file = f"{os.getenv("LOG_ROOT")}/resume_time_results.json"
+    data = []
+
+    if Path(results_file).is_file():
+        with open(results_file, 'r') as f:
+            data = json.load(f)
+            print(f"data: {data}")
+
+    data.append(results)
+
+    with open(results_file, "w") as f:
+        f.write(json.dumps(data))
+    return results_file
+    
+
+if __name__ == "__main__":
+    if len(sys.argv) != 3:
+        print("Incorrect args. Usage: python3 analyze-sleepgraph-results.py <path_to_html_file> <thresholds_as_json_str>")
+        sys.exit(1)
+
+    sleepgraph_file = sys.argv[1]
+    thresholds = json.loads(sys.argv[2])
+    
+    test_passed, results = analyze_sleepgraph_file(sleepgraph_file, thresholds)
+    print(f"Sleepgraph report analysis passed: {test_passed}")
+
+    results_file = save_results_to_file(results)
+    print(f"Saved results to file: {results_file}")
+    
+    sys.exit(0 if test_passed else 1)
