Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing/style guide #74

Open
heartsucker opened this issue Jun 22, 2017 · 3 comments
Open

Add contributing/style guide #74

heartsucker opened this issue Jun 22, 2017 · 3 comments

Comments

@heartsucker
Copy link
Contributor

Even just to keep myself organized. Off the top of my head, it should include things like what to log and at what level to log it.

@lucab
Copy link
Contributor

lucab commented Jun 26, 2017

Some mention of rustfmt, perhaps? It would be nice to know that I can just blindly cargo fmt all PRs, or that there is a custom rustfmt.toml config manifest in case of customizations.

@heartsucker
Copy link
Contributor Author

heartsucker commented Jun 26, 2017

I'm using rustfmt = 0.9.4 right now, but I haven't set up a rustfmt.toml. If you have have recommendations, I'm all ears. Annoyingly, the RSA prime in src/rsa/mod.rs doesn't respond well to the annotations telling rustfmt to ignore it, so I have to do a patch and then checkout that bit each time grumble grumble.

@heartsucker
Copy link
Contributor Author

And if that was all tricked out and added, it would actually be nice to enforce cargo fmt in the Travis build to make future diffs cleaner.

erickt added a commit to erickt/rust-tuf that referenced this issue Jul 17, 2018
This falls under theupdateframework#74. I didn't see anything particularly
egregious in the output.
erickt added a commit to erickt/rust-tuf that referenced this issue Jul 18, 2018
This falls under theupdateframework#74. I didn't see anything particularly
egregious in the output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants