Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved message for meeting previous and current thresholds #206

Open
haydentherapper opened this issue Feb 28, 2024 · 3 comments
Open

Comments

@haydentherapper
Copy link

Context PR: sigstore/root-signing-staging#57

When a threshold is updated, both the previous threshold with the previous set of keys and the new threshold with the latest set of keys must be met. The current message is "Role root is not yet verified. It is signed by 1/1 (1/2) signers ", where the first ratio is the previous threshold, the second ratio is the new threshold. To make this clearer, it would be helpful to denote which of these ratios is the previous or current threshold. Maybe something like " role is not yet verified. Previous threshold met (1/1). Current threshold not yet verified (1/2)." Could also include the version, like "Previous threshold for version X met, current threshold for X+1 not".

@jku
Copy link
Member

jku commented Feb 28, 2024

role is not yet verified. Previous threshold met (1/1). Current threshold not yet verified (1/2).

My goal with the messages has been to keep them as short as possible (I already find myself not reading them all the way and I bet others have the same problem): this has so far prevented improving this string... your suggestion is pretty good though, should fit on a single line. I'm not sure everyone immediately knows what threshold means here though.

Another option might be to move the "verified/not verified" to the title:


❌ root (not verified yet)

Previous threshold met (1/1). Current threshold not met (1/2). Signed by @jku
Still missing signatures from @-kommendorkapten, @-mnm678, @-repo-import, @-joshuagl
Signers can sign these changes by running tuf-on-ci-sign sign/staging-with-more-signers

@haydentherapper
Copy link
Author

I like moving the status into the title, lets verifiers quickly glance to see the status.

@joshuagl
Copy link
Member

Another option might be to move the "verified/not verified" to the title:

The suggestion here is a great. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants