[Dashboard] Fix: Update PayAnalytics component to use projectClientId instead of … #7233

gregfromstl · 2025-05-30T20:34:16Z

…clientId for better clarity in prop usage

PR-Codex overview

This PR updates the PayAnalytics component to use props.projectClientId instead of props.clientId when rendering the PayEmbedFTUX component, ensuring the correct client ID is passed.

Detailed summary

Changed the clientId prop in the PayEmbedFTUX component from props.clientId to props.projectClientId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Resolved an issue that could cause errors when displaying the Pay Analytics component in cases with no volume or wallet data.

…clientId for better clarity in prop usage

changeset-bot · 2025-05-30T20:34:20Z

⚠️ No Changeset found

Latest commit: 2640b93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-05-30T20:34:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2025 8:42pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	May 30, 2025 8:42pm
login	⬜️ Skipped (Inspect)	May 30, 2025 8:42pm
thirdweb_playground	⬜️ Skipped (Inspect)	May 30, 2025 8:42pm
wallet-ui	⬜️ Skipped (Inspect)	May 30, 2025 8:42pm

graphite-app · 2025-05-30T20:34:22Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai · 2025-05-30T20:34:24Z

Walkthrough

The change corrects the prop name passed to the PayEmbedFTUX component within PayAnalytics.tsx, replacing an incorrect reference to clientId with the correct projectClientId, aligning with the declared prop names and preventing a potential runtime error.

Changes

File(s)	Change Summary
apps/dashboard/src/components/pay/PayAnalytics/PayAnalytics.tsx	Fixed prop name from `clientId` to `projectClientId` when passing to `PayEmbedFTUX`.

Possibly related PRs

[Dashboard] add empty state for Pay analytics #7206: Introduced the PayEmbedFTUX component and its usage in PayAnalytics.tsx as an empty state fallback, directly related to the prop name fix in this PR.

Suggested labels

Dashboard

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 196cb54 and 2640b93.

📒 Files selected for processing (1)

apps/dashboard/src/components/pay/PayAnalytics/PayAnalytics.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Build Packages
GitHub Check: Lint Packages
GitHub Check: Unit Tests
GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

apps/dashboard/src/components/pay/PayAnalytics/PayAnalytics.tsx (1)

63-63: LGTM! Good catch fixing the undefined prop reference.

This change correctly fixes a bug where props.clientId (which doesn't exist in the PayAnalytics props interface) was being passed to PayEmbedFTUX. The fix properly uses props.projectClientId which is defined in the component's props interface on line 17, ensuring the PayEmbedFTUX component receives the correct client ID value instead of undefined.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-05-30T20:35:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (196cb54) to head (2640b93).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7233   +/-   ##
=======================================
  Coverage   55.62%   55.62%           
=======================================
  Files         908      908           
  Lines       58575    58575           
  Branches     4132     4132           
=======================================
  Hits        32582    32582           
  Misses      25886    25886           
  Partials      107      107

Flag	Coverage Δ
packages	`55.62% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-30T20:38:49Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.14 KB (0%)	1.3 s (0%)	191 ms (+156.08% 🔺)	1.5 s
thirdweb (cjs)	344.83 KB (0%)	6.9 s (0%)	611 ms (-4.63% 🔽)	7.6 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	45 ms (+858.96% 🔺)	159 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	29 ms (+1665.44% 🔺)	39 ms
thirdweb/react (minimal + tree-shaking)	19.52 KB (0%)	391 ms (0%)	67 ms (+472.43% 🔺)	457 ms

Fix: Update PayAnalytics component to use projectClientId instead of …

2640b93

…clientId for better clarity in prop usage

gregfromstl requested review from a team as code owners May 30, 2025 20:34

github-actions bot assigned gregfromstl May 30, 2025

github-actions bot added the Dashboard label May 30, 2025

vercel bot deployed to Preview – thirdweb-www May 30, 2025 20:42 View deployment

gregfromstl closed this May 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Fix: Update PayAnalytics component to use projectClientId instead of … #7233

[Dashboard] Fix: Update PayAnalytics component to use projectClientId instead of … #7233

gregfromstl commented May 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 30, 2025

Uh oh!

vercel bot commented May 30, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 30, 2025

Uh oh!

coderabbitai bot commented May 30, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

[Dashboard] Fix: Update PayAnalytics component to use projectClientId instead of … #7233

[Dashboard] Fix: Update PayAnalytics component to use projectClientId instead of … #7233

Conversation

gregfromstl commented May 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Uh oh!

vercel bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented May 30, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 30, 2025

size-limit report 📦

Uh oh!

gregfromstl commented May 30, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 30, 2025 •

edited

Loading

coderabbitai bot commented May 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 30, 2025 •

edited

Loading